qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: quintela@redhat.com, liang.z.li@intel.com, mjt@tls.msk.ru,
	qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause
Date: Tue, 17 Feb 2015 13:27:03 +0000	[thread overview]
Message-ID: <20150217132703.GE2291@work-vm> (raw)
In-Reply-To: <20150217124643.GA13104@grmbl.mre>

* Amit Shah (amit.shah@redhat.com) wrote:
> On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > This patchset provides a way of setting options on an incoming
> > migration before the fd/process/socket has been created.
> > 
> >    start qemu with   -incoming pause
> >    <use the monitor to set whatever you need>
> >    migrate_incoming theuri
> > 
> > v2:
> >   Create migrate_incoming/migrate-incoming rather than squashing the -u
> >   into the existing migrate command.
> 
> So the only comment I have is with the 'pause' name.
> 
> 'pause' to me means there's a time period for which a pause has to be
> done; or pausing an activity which is already in progress, both of
> which are not true for this case.

I think that pause and wait are both pretty similar; wait generally
does mean wait for something specific though.

The 'pause' button on your video player doesn't have an expectation
of how long you will pause it.

> My suggestions are 'wait' or 'hold' -- wait signifies we wait for a
> connection; the uri for which we give later; similar for hold.

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2015-02-17 13:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11 16:46 [Qemu-devel] [PATCH v2 0/3] -incoming pause Dr. David Alan Gilbert (git)
2015-02-11 16:46 ` [Qemu-devel] [PATCH v2 1/3] Add " Dr. David Alan Gilbert (git)
2015-02-11 16:46 ` [Qemu-devel] [PATCH v2 2/3] Add migrate_incoming Dr. David Alan Gilbert (git)
2015-02-11 17:19   ` Eric Blake
2015-02-11 18:24     ` Juan Quintela
2015-02-11 18:20   ` Juan Quintela
2015-02-11 18:22     ` Dr. David Alan Gilbert
2015-02-11 16:46 ` [Qemu-devel] [PATCH v2 3/3] Document -incoming options Dr. David Alan Gilbert (git)
2015-02-17 12:46 ` [Qemu-devel] [PATCH v2 0/3] -incoming pause Amit Shah
2015-02-17 13:27   ` Dr. David Alan Gilbert [this message]
2015-02-17 14:59     ` Amit Shah
2015-02-17 16:14       ` Eric Blake
2015-02-17 20:13         ` Dr. David Alan Gilbert
2015-02-18  5:43           ` Amit Shah
2015-02-18  5:40         ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150217132703.GE2291@work-vm \
    --to=dgilbert@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=liang.z.li@intel.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).