Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

[Amit Shah <amit.shah@redhat.com>]

On (Tue) 17 Feb 2015 [13:27:03], Dr. David Alan Gilbert wrote:
> * Amit Shah (amit.shah@redhat.com) wrote:
> > On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote:
> > > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > > 
> > > This patchset provides a way of setting options on an incoming
> > > migration before the fd/process/socket has been created.
> > > 
> > >    start qemu with   -incoming pause
> > >    <use the monitor to set whatever you need>
> > >    migrate_incoming theuri
> > > 
> > > v2:
> > >   Create migrate_incoming/migrate-incoming rather than squashing the -u
> > >   into the existing migrate command.
> > 
> > So the only comment I have is with the 'pause' name.
> > 
> > 'pause' to me means there's a time period for which a pause has to be
> > done; or pausing an activity which is already in progress, both of
> > which are not true for this case.
> 
> I think that pause and wait are both pretty similar; wait generally
> does mean wait for something specific though.
> 
> The 'pause' button on your video player doesn't have an expectation
> of how long you will pause it.

Right; but it pauses an already-playing video.  We're not pausing an
incoming migration here; we're not even started.

So pause in the migration world will make sense (to me, of course)
when we actually pause an ongoing migration...


		Amit