From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNjcR-0002g1-Di for qemu-devel@nongnu.org; Tue, 17 Feb 2015 09:59:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNjcM-0006ze-LZ for qemu-devel@nongnu.org; Tue, 17 Feb 2015 09:59:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNjcM-0006zQ-FD for qemu-devel@nongnu.org; Tue, 17 Feb 2015 09:59:18 -0500 Date: Tue, 17 Feb 2015 20:29:13 +0530 From: Amit Shah Message-ID: <20150217145913.GA13553@grmbl.mre> References: <1423673184-5903-1-git-send-email-dgilbert@redhat.com> <20150217124643.GA13104@grmbl.mre> <20150217132703.GE2291@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150217132703.GE2291@work-vm> Subject: Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: quintela@redhat.com, liang.z.li@intel.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, pbonzini@redhat.com On (Tue) 17 Feb 2015 [13:27:03], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.shah@redhat.com) wrote: > > On (Wed) 11 Feb 2015 [16:46:21], Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > This patchset provides a way of setting options on an incoming > > > migration before the fd/process/socket has been created. > > > > > > start qemu with -incoming pause > > > > > > migrate_incoming theuri > > > > > > v2: > > > Create migrate_incoming/migrate-incoming rather than squashing the -u > > > into the existing migrate command. > > > > So the only comment I have is with the 'pause' name. > > > > 'pause' to me means there's a time period for which a pause has to be > > done; or pausing an activity which is already in progress, both of > > which are not true for this case. > > I think that pause and wait are both pretty similar; wait generally > does mean wait for something specific though. > > The 'pause' button on your video player doesn't have an expectation > of how long you will pause it. Right; but it pauses an already-playing video. We're not pausing an incoming migration here; we're not even started. So pause in the migration world will make sense (to me, of course) when we actually pause an ongoing migration... Amit