From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] virtio-blk: Check return value of blk_aio_ioctl
Date: Tue, 17 Feb 2015 17:10:52 +0100 [thread overview]
Message-ID: <20150217161052.GH4213@noname.str.redhat.com> (raw)
In-Reply-To: <20150217154050.GE25998@stefanha-thinkpad.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
Am 17.02.2015 um 16:40 hat Stefan Hajnoczi geschrieben:
> On Tue, Feb 17, 2015 at 05:55:53PM +0800, Fam Zheng wrote:
> > Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose
> > the request if blk_aio_ioctl returns NULL (not implemented).
> >
> > Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we used to do.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> >
> > ---
> > v2: Fix the leak of ioctl_req. (Kevin)
> > ---
> > hw/block/virtio-blk.c | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks, applied to the block branch.
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2015-02-17 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 9:55 [Qemu-devel] [PATCH v2] virtio-blk: Check return value of blk_aio_ioctl Fam Zheng
2015-02-17 15:40 ` Stefan Hajnoczi
2015-02-17 16:10 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217161052.GH4213@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).