From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNoWW-000302-5m for qemu-devel@nongnu.org; Tue, 17 Feb 2015 15:13:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNoWS-0006ab-So for qemu-devel@nongnu.org; Tue, 17 Feb 2015 15:13:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNoWS-0006aP-L5 for qemu-devel@nongnu.org; Tue, 17 Feb 2015 15:13:32 -0500 Date: Tue, 17 Feb 2015 20:13:25 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20150217201324.GI2291@work-vm> References: <1423673184-5903-1-git-send-email-dgilbert@redhat.com> <20150217124643.GA13104@grmbl.mre> <20150217132703.GE2291@work-vm> <20150217145913.GA13553@grmbl.mre> <54E368E3.9060105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54E368E3.9060105@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: quintela@redhat.com, liang.z.li@intel.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, Amit Shah , pbonzini@redhat.com * Eric Blake (eblake@redhat.com) wrote: > On 02/17/2015 07:59 AM, Amit Shah wrote: > >>> > >>> So the only comment I have is with the 'pause' name. > >>> > >>> 'pause' to me means there's a time period for which a pause has to be > >>> done; or pausing an activity which is already in progress, both of > >>> which are not true for this case. > >> > >> I think that pause and wait are both pretty similar; wait generally > >> does mean wait for something specific though. > >> > >> The 'pause' button on your video player doesn't have an expectation > >> of how long you will pause it. > > > > Right; but it pauses an already-playing video. We're not pausing an > > incoming migration here; we're not even started. > > > > So pause in the migration world will make sense (to me, of course) > > when we actually pause an ongoing migration... > > As long as we are bike-shedding, would 'defer' be any nicer, as an > indication that we are deferring the actual migration until the QMP > command starts it? I'm happy with any of them (as I assume were those who R-b'd the set). If people really think it needs to change then fine, I'm happy to recut and retest it. But if it's just bike-shedding, then I'd rather not. Dave > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK