Re: [Qemu-devel] [PATCH v2 0/3] -incoming pause

[Amit Shah <amit.shah@redhat.com>]

On (Tue) 17 Feb 2015 [20:13:25], Dr. David Alan Gilbert wrote:
> * Eric Blake (eblake@redhat.com) wrote:
> > On 02/17/2015 07:59 AM, Amit Shah wrote:
> > >>>
> > >>> So the only comment I have is with the 'pause' name.
> > >>>
> > >>> 'pause' to me means there's a time period for which a pause has to be
> > >>> done; or pausing an activity which is already in progress, both of
> > >>> which are not true for this case.
> > >>
> > >> I think that pause and wait are both pretty similar; wait generally
> > >> does mean wait for something specific though.
> > >>
> > >> The 'pause' button on your video player doesn't have an expectation
> > >> of how long you will pause it.
> > > 
> > > Right; but it pauses an already-playing video.  We're not pausing an
> > > incoming migration here; we're not even started.
> > > 
> > > So pause in the migration world will make sense (to me, of course)
> > > when we actually pause an ongoing migration...
> > 
> > As long as we are bike-shedding, would 'defer' be any nicer, as an
> > indication that we are deferring the actual migration until the QMP
> > command starts it?
> 
> I'm happy with any of them (as I assume were those who R-b'd the set).
> 
> If people really think it needs to change then fine, I'm happy
> to recut and retest it.  But if it's just bike-shedding, then I'd
> rather not.

One of the reasons for me raising this is the line:

'Pausing an already paused guest'

comparing that to:

'Incoming migration already deferred'

or some construct like that is much clearer.

The former just adds to the confusion and the mess we have with
migration error messages.  You've already done a good job fixing many
of our existing error and debug messages, so it'll be great to avoid
introducing one.

Thanks,

		Amit