From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, afaerber@suse.de,
quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/1] unbreak dtrace tracing due to double _ in rdma names
Date: Wed, 18 Feb 2015 10:52:35 +0000 [thread overview]
Message-ID: <20150218105235.GA7629@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1424105885-12149-1-git-send-email-dgilbert@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
On Mon, Feb 16, 2015 at 04:58:05PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> It looks like the dtrace trace code gets upset if you have trace names
> with __ in, which the migration/rdma.c code does.
>
> Rename the functions and the associated traces.
>
> Fixes: 733252deb8b7d37beacda5976c2769e18642b2fa
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reported-by: Andreas Färber <afaerber@suse.de>
> ---
> migration/rdma.c | 24 +++++++++++-------------
> trace-events | 4 ++--
> 2 files changed, 13 insertions(+), 15 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-02-18 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 16:58 [Qemu-devel] [PATCH 1/1] unbreak dtrace tracing due to double _ in rdma names Dr. David Alan Gilbert (git)
2015-02-16 17:06 ` Paolo Bonzini
2015-02-16 18:03 ` Andreas Färber
2015-02-18 10:52 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218105235.GA7629@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).