From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests
Date: Wed, 18 Feb 2015 13:39:38 +0100 [thread overview]
Message-ID: <20150218123938.GD4996@noname.str.redhat.com> (raw)
In-Reply-To: <1424208819-10306-1-git-send-email-mreitz@redhat.com>
Am 17.02.2015 um 22:33 hat Max Reitz geschrieben:
> Concurrently modifying the bmap is not a good idea;
Why? I mean, the fact that this fixes something for you probably means
that there really is some piece of local state that is invalidated by
concurrent writes, but it's not obvious to me what it is.
What could obviously happen is that metadata is written before the data
is on the disk, but as we don't support backing files for VDI, this is
irrelvant. (And if it were relevant, it stil wouldn't be fixed by your
patch because the driver never flushes.)
> this patch adds a
> lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what
> can go wrong without.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Kevin
next prev parent reply other threads:[~2015-02-18 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 21:33 [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests Max Reitz
2015-02-17 21:49 ` Paolo Bonzini
2015-02-17 21:49 ` Max Reitz
2015-02-18 7:52 ` Paolo Bonzini
2015-02-18 15:10 ` Max Reitz
2015-02-18 12:39 ` Kevin Wolf [this message]
2015-02-18 15:09 ` Max Reitz
2015-02-27 11:25 ` Stefan Hajnoczi
2015-02-27 11:43 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218123938.GD4996@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).