From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YO6ki-0003kx-2N
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 10:41:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YO6ke-00006A-RY
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 10:41:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37451)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YO6ke-00005z-JN
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 10:41:24 -0500
Date: Wed, 18 Feb 2015 16:41:08 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150218154108.GA4659@redhat.com>
References: <1424122283-12521-1-git-send-email-mst@redhat.com>
	<1424122283-12521-12-git-send-email-mst@redhat.com>
	<20150218153413.390d8d05@oc7435384737.ibm.com>
	<20150218145554.GA3913@redhat.com>
	<20150218163639.684cbffd@oc7435384737.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150218163639.684cbffd@oc7435384737.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v3 11/17] virtio-serial: switch to
 standard-headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@linux.vnet.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@amazon.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Amit Shah <amit.shah@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, "Chen,
	Tiejun" <tiejun.chen@intel.com>

On Wed, Feb 18, 2015 at 04:36:39PM +0100, Thomas Huth wrote:
> On Wed, 18 Feb 2015 15:55:54 +0100
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > On Wed, Feb 18, 2015 at 03:34:13PM +0100, Thomas Huth wrote:
> > > On Mon, 16 Feb 2015 22:36:26 +0100
> > > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> ...
> > > > diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> > > > index 47fbb34..a2bac9b 100644
> > > > --- a/hw/char/virtio-serial-bus.c
> > > > +++ b/hw/char/virtio-serial-bus.c
> > > > @@ -18,6 +18,7 @@
> > > >   * GNU GPL, version 2 or (at your option) any later version.
> > > >   */
> > > > 
> > > > +#include "standard-headers/linux/virtio_ids.h"
> > > 
> > > Could you omit this include? Later in virtio-serial-bus.c, the code
> > > includes hw/virtio/virtio-serial.h, which in turn includes
> > > standard-headers/linux/virtio_console.h - and that one already includes
> > > the ids.h file. So I think it should work without the above change, too.
> > > 
> > >  Thomas
> > 
> > Yes but it's generally not a good idea to depend on headers
> > including each other.
>  
> But as far as I can see, you also did not do this change in your other
> patches of this series, so this seems a little bit inconsequent (e.g.
> virtio-blk.c depends on VIRTIO_ID_BLOCK, but you did not include the
> virtio_ids.h header there).
> 
>  Thomas

OK - I'll do this as a patch on top?
Don't want to repost the whole series.

-- 
MST