From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57277)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peff@peff.net>) id 1YO9pF-00032J-8o
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 13:58:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peff@peff.net>) id 1YO9pA-0006Or-NQ
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 13:58:21 -0500
Received: from cloud.peff.net ([50.56.180.127]:44261)
	by eggs.gnu.org with smtp (Exim 4.71) (envelope-from <peff@peff.net>)
	id 1YO9pA-0006OP-HJ
	for qemu-devel@nongnu.org; Wed, 18 Feb 2015 13:58:16 -0500
Date: Wed, 18 Feb 2015 13:58:12 -0500
From: Jeff King <peff@peff.net>
Message-ID: <20150218185812.GC7257@peff.net>
References: <cover.1421214154.git.zhugh.fnst@cn.fujitsu.com>
	<20150205114914.GA10126@stefanha-thinkpad.redhat.com>
	<54D38B73.4060803@redhat.com>
	<xmqqiofgkvi4.fsf@gitster.dls.corp.google.com>
	<20150205195758.GC15326@peff.net>
	<xmqq61bgkt9w.fsf@gitster.dls.corp.google.com>
	<CAMuHMdWbHMPEwkYvzKzzc6L0T8ufk62DGS2sZ1w1BthL1kAZWA@mail.gmail.com>
	<xmqqiof14hax.fsf_-_@gitster.dls.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <xmqqiof14hax.fsf_-_@gitster.dls.corp.google.com>
Subject: Re: [Qemu-devel] [PATCH] send-email: ask confirmation if given
 encoding name is very short
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Junio C Hamano <gitster@pobox.com>
Cc: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, guz.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Geert Uytterhoeven <geert@linux-m68k.org>, anshul.makkar@profitbricks.com, chen.fan.fnst@cn.fujitsu.com, imammedo@redhat.com, afaerber@suse.de, git@vger.kernel.org

On Mon, Feb 16, 2015 at 02:34:14PM -0800, Junio C Hamano wrote:

> Sometimes people respond "y<ENTER>" (or "yes<ENTER>") when asked
> this question:
> 
>     Which 8bit encoding should I declare [UTF-8]?
> 
> We already have a mechanism to avoid accepting a mistyped e-mail
> address (we ask to confirm when the given address lacks "@" in it);
> reuse it to trigger the same confirmation when given a very short
> answer.  As a typical charset name is probably at least 4 chars or
> longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would
> prevent such a mistake.
> 
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> 
>  * Will mark to be merged to 'next'.

Probably belated review, but this looks good to me.

-Peff