[Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[David Gibson]

As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist
on any platform with a PCI bus.  However in practice, they're Intel
specific devices, that are very unlikely to appear on anything other than
an x86.  Therefore this patch gives them their own config options, enabled
only for x86 targets by default.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 default-configs/i386-softmmu.mak | 2 ++
 hw/pci-bridge/Makefile.objs      | 5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
index bd99af9..609c73a 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -43,3 +43,5 @@ CONFIG_IOAPIC=y
 CONFIG_ICC_BUS=y
 CONFIG_PVPANIC=y
 CONFIG_MEM_HOTPLUG=y
+CONFIG_IOH3420=y
+CONFIG_I82801B11=y
diff --git a/hw/pci-bridge/Makefile.objs b/hw/pci-bridge/Makefile.objs
index 968b369..2715721 100644
--- a/hw/pci-bridge/Makefile.objs
+++ b/hw/pci-bridge/Makefile.objs
@@ -1,5 +1,6 @@
 common-obj-y += pci_bridge_dev.o
-common-obj-y += ioh3420.o xio3130_upstream.o xio3130_downstream.o
-common-obj-y += i82801b11.o
+common-obj-y += xio3130_upstream.o xio3130_downstream.o
+common-obj-$(CONFIG_IOH3420) += ioh3420.o
+common-obj-$(CONFIG_I82801B11) += i82801b11.o
 # NewWorld PowerMac
 common-obj-$(CONFIG_DEC_PCI) += dec.o
-- 
2.1.0

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

On Wed, Feb 18, 2015 at 03:59:56PM +1100, David Gibson wrote:
> As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist
> on any platform with a PCI bus.  However in practice, they're Intel
> specific devices, that are very unlikely to appear on anything other than
> an x86.  Therefore this patch gives them their own config options, enabled
> only for x86 targets by default.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Guh.  I'm an idiot - left out the x86_64-softmmu.mak file.  I'll
resend if people think the concept is ok.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[Paolo Bonzini]

On 18/02/2015 05:59, David Gibson wrote:
> As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist
> on any platform with a PCI bus.  However in practice, they're Intel
> specific devices,

They can be used as a generic PCIe root port and PCIe-to-PCI bridge,
they're not Intel-specific as long as your firmware doesn't care about
the vendor and device id.

> that are very unlikely to appear on anything other than
> an x86.  Therefore this patch gives them their own config options, enabled
> only for x86 targets by default.

I think it's quite likely that we'll use them, or at least ioh3420, on
any PCIe machine.  So you probably want to add ioh3420 to arm-softmmu
and aarch64-softmmu as well.  I don't know about i82801b11, but it
doesn't hurt to have it in ARM/AArch64 either.

Also, the same can be done for xio3130, so you can also limit that one
to x86 and ARM/Aarch64.

Paolo

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

On Wed, Feb 18, 2015 at 08:57:39AM +0100, Paolo Bonzini wrote:
> 
> 
> On 18/02/2015 05:59, David Gibson wrote:
> > As PCI devices, the i82801b11 and ioh3420 devices could theoretically exist
> > on any platform with a PCI bus.  However in practice, they're Intel
> > specific devices,
> 
> They can be used as a generic PCIe root port and PCIe-to-PCI bridge,
> they're not Intel-specific as long as your firmware doesn't care about
> the vendor and device id.

Hm, ok.

> > that are very unlikely to appear on anything other than
> > an x86.  Therefore this patch gives them their own config options, enabled
> > only for x86 targets by default.
> 
> I think it's quite likely that we'll use them, or at least ioh3420, on
> any PCIe machine.  So you probably want to add ioh3420 to arm-softmmu
> and aarch64-softmmu as well.  I don't know about i82801b11, but it
> doesn't hurt to have it in ARM/AArch64 either.
> 
> Also, the same can be done for xio3130, so you can also limit that one
> to x86 and ARM/Aarch64.

Ok, I'll revise accordingly.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[Peter Maydell]

On 18 February 2015 at 16:57, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 18/02/2015 05:59, David Gibson wrote:
>> that are very unlikely to appear on anything other than
>> an x86.  Therefore this patch gives them their own config options, enabled
>> only for x86 targets by default.
>
> I think it's quite likely that we'll use them, or at least ioh3420, on
> any PCIe machine.  So you probably want to add ioh3420 to arm-softmmu
> and aarch64-softmmu as well.  I don't know about i82801b11, but it
> doesn't hurt to have it in ARM/AArch64 either.

What's the motivation for narrowing these down to particular
configs anyway?

-- PMM

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]


On Thu, Feb 19, 2015 at 12:45:23PM +0900, Peter Maydell wrote:
> On 18 February 2015 at 16:57, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > On 18/02/2015 05:59, David Gibson wrote:
> >> that are very unlikely to appear on anything other than
> >> an x86.  Therefore this patch gives them their own config options, enabled
> >> only for x86 targets by default.
> >
> > I think it's quite likely that we'll use them, or at least ioh3420, on
> > any PCIe machine.  So you probably want to add ioh3420 to arm-softmmu
> > and aarch64-softmmu as well.  I don't know about i82801b11, but it
> > doesn't hurt to have it in ARM/AArch64 either.
> 
> What's the motivation for narrowing these down to particular
> configs anyway?

Simply to avoid probably-irrelevant devices showing up in qemu -device
?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[Michael S. Tsirkin]

On Thu, Feb 19, 2015 at 04:20:36PM +1100, David Gibson wrote:
> 
> On Thu, Feb 19, 2015 at 12:45:23PM +0900, Peter Maydell wrote:
> > On 18 February 2015 at 16:57, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > > On 18/02/2015 05:59, David Gibson wrote:
> > >> that are very unlikely to appear on anything other than
> > >> an x86.  Therefore this patch gives them their own config options, enabled
> > >> only for x86 targets by default.
> > >
> > > I think it's quite likely that we'll use them, or at least ioh3420, on
> > > any PCIe machine.  So you probably want to add ioh3420 to arm-softmmu
> > > and aarch64-softmmu as well.  I don't know about i82801b11, but it
> > > doesn't hurt to have it in ARM/AArch64 either.
> > 
> > What's the motivation for narrowing these down to particular
> > configs anyway?
> 
> Simply to avoid probably-irrelevant devices showing up in qemu -device
> ?

And make the binary smaller.

-- 
MST

Re: [Qemu-devel] [PATCH] Make i82801b11 and ioh3420 x86 only by default

[Paolo Bonzini]

On 19/02/2015 04:45, Peter Maydell wrote:
> > I think it's quite likely that we'll use them, or at least ioh3420, on
> > any PCIe machine.  So you probably want to add ioh3420 to arm-softmmu
> > and aarch64-softmmu as well.  I don't know about i82801b11, but it
> > doesn't hurt to have it in ARM/AArch64 either.
>
> What's the motivation for narrowing these down to particular
> configs anyway?

They do not make sense if you do not have a PCIe bus.

Paolo