From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: cornelia.huck@de.ibm.com,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-devel@nongnu.org,
Raushaniya Maksudova <rmaksudova@parallels.com>
Subject: Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init
Date: Thu, 19 Feb 2015 11:29:27 +0100 [thread overview]
Message-ID: <20150219102927.GA24587@redhat.com> (raw)
In-Reply-To: <54E5B987.9070202@openvz.org>
On Thu, Feb 19, 2015 at 01:23:03PM +0300, Denis V. Lunev wrote:
> >The problem is code duplication: all transports need to know
> >about these balloon-specific property.
> >Why isn't it handled by virtio_instance_init_common?
> >
> why it should?
>
> virtio_instance_init_common is common for all virtio devices
> including VirtIO net, VirtIO block, VirtIO SCSI. Thus the patch
> move initialization of all common stuff into the common
> code.
The problem seems common enough, virtio_instance_init_common
already works for all properties, why not for these ones?
next prev parent reply other threads:[~2015-02-19 10:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 14:24 [Qemu-devel] [RESEND PATCH v3 0/2] balloon: add a feature bit to let Guest OS deflate virtio_balloon on OOM Denis V. Lunev
2015-01-29 14:24 ` [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init Denis V. Lunev
2015-02-19 9:25 ` Michael S. Tsirkin
2015-02-19 9:36 ` Denis V. Lunev
2015-02-19 9:39 ` Michael S. Tsirkin
2015-02-19 9:46 ` Denis V. Lunev
2015-02-19 10:17 ` Michael S. Tsirkin
2015-02-19 10:23 ` Denis V. Lunev
2015-02-19 10:29 ` Michael S. Tsirkin [this message]
2015-02-19 11:26 ` Cornelia Huck
2015-02-26 17:01 ` Denis V. Lunev
2015-02-26 17:04 ` Michael S. Tsirkin
2015-01-29 14:24 ` [Qemu-devel] [RESEND PATCH 2/2] balloon: add a feature bit to let Guest OS deflate balloon on oom Denis V. Lunev
2015-02-19 5:41 ` [Qemu-devel] [RESEND PATCH v3 0/2] balloon: add a feature bit to let Guest OS deflate virtio_balloon on OOM Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219102927.GA24587@redhat.com \
--to=mst@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=den@openvz.org \
--cc=qemu-devel@nongnu.org \
--cc=rmaksudova@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).