From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YOOMX-0004m4-GN
	for qemu-devel@nongnu.org; Thu, 19 Feb 2015 05:29:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YOOMR-0000Rz-VG
	for qemu-devel@nongnu.org; Thu, 19 Feb 2015 05:29:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:45907)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YOOMR-0000Rf-Nb
	for qemu-devel@nongnu.org; Thu, 19 Feb 2015 05:29:35 -0500
Date: Thu, 19 Feb 2015 11:29:27 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150219102927.GA24587@redhat.com>
References: <1422541482-2839-1-git-send-email-den@openvz.org>
	<1422541482-2839-2-git-send-email-den@openvz.org>
	<20150219092541.GA19380@redhat.com> <54E5AEA5.8030407@openvz.org>
	<20150219093941.GB19380@redhat.com> <54E5B0FA.3010505@openvz.org>
	<20150219101732.GA24499@redhat.com> <54E5B987.9070202@openvz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54E5B987.9070202@openvz.org>
Subject: Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call
 qdev_alias_all_properties for proxy dev in balloon class init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: cornelia.huck@de.ibm.com, Christian Borntraeger <borntraeger@de.ibm.com>, qemu-devel@nongnu.org, Raushaniya Maksudova <rmaksudova@parallels.com>

On Thu, Feb 19, 2015 at 01:23:03PM +0300, Denis V. Lunev wrote:
> >The problem is code duplication: all transports need to know
> >about these balloon-specific property.
> >Why isn't it handled by virtio_instance_init_common?
> >
> why it should?
> 
> virtio_instance_init_common is common for all virtio devices
> including VirtIO net, VirtIO block, VirtIO SCSI. Thus the patch
> move initialization of all common stuff into the common
> code.

The problem seems common enough, virtio_instance_init_common
already works for all properties, why not for these ones?