From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOktY-0007yI-6R for qemu-devel@nongnu.org; Fri, 20 Feb 2015 05:33:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOktU-0007fe-5Q for qemu-devel@nongnu.org; Fri, 20 Feb 2015 05:33:16 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:60332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOktT-0007fU-S2 for qemu-devel@nongnu.org; Fri, 20 Feb 2015 05:33:12 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Feb 2015 10:33:10 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8A2181B0804B for ; Fri, 20 Feb 2015 10:33:21 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1KAX83b64684146 for ; Fri, 20 Feb 2015 10:33:08 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1K5SZ6H015094 for ; Fri, 20 Feb 2015 00:28:35 -0500 From: Greg Kurz Date: Fri, 20 Feb 2015 11:33:06 +0100 Message-ID: <20150220103306.22408.19213.stgit@bahia.local> In-Reply-To: <20150220103253.22408.6807.stgit@bahia.local> References: <20150220103253.22408.6807.stgit@bahia.local> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 2/2] vhost_net: re-enable when cross endian List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Cedric Le Goater , qemu-devel@nongnu.org From: Cédric Le Goater revert 371df9f5e0f1 "vhost-net: disable when cross-endian" Signed-off-by: Cédric Le Goater Signed-off-by: Greg Kurz --- hw/net/vhost_net.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 4e3a061..721fb2d 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -271,19 +271,6 @@ static void vhost_net_stop_one(struct vhost_net *net, vhost_dev_disable_notifiers(&net->dev, dev); } -static bool vhost_net_device_endian_ok(VirtIODevice *vdev) -{ -#ifdef TARGET_IS_BIENDIAN -#ifdef HOST_WORDS_BIGENDIAN - return virtio_is_big_endian(vdev); -#else - return !virtio_is_big_endian(vdev); -#endif -#else - return true; -#endif -} - int vhost_net_start(VirtIODevice *dev, NetClientState *ncs, int total_queues) { @@ -292,12 +279,6 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs, VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus); int r, e, i; - if (!vhost_net_device_endian_ok(dev)) { - error_report("vhost-net does not support cross-endian"); - r = -ENOSYS; - goto err; - } - if (!k->set_guest_notifiers) { error_report("binding does not support guest notifiers"); r = -ENOSYS;