From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, pl@kamp.de, qemu-stable@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com, wu.wubin@huawei.com
Subject: Re: [Qemu-devel] [PATCH 1/3] coroutine: Fix use after free with qemu_coroutine_yield()
Date: Fri, 20 Feb 2015 16:05:01 +0100 [thread overview]
Message-ID: <20150220150501.GE4464@noname.redhat.com> (raw)
In-Reply-To: <1423564888-14933-2-git-send-email-kwolf@redhat.com>
Am 10.02.2015 um 11:41 hat Kevin Wolf geschrieben:
> Instead of using the same function for entering and exiting coroutines,
> and hoping that it doesn't add any functionality that hurts with the
> parameters used for exiting, we can just directly call into the real
> task switch in qemu_coroutine_switch().
>
> This fixes a use-after-free scenario where reentering a coroutine that
> has yielded still accesses the old parent coroutine (which may have
> meanwhile terminated) in the part of coroutine_swap() that follows
> qemu_coroutine_switch().
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-stable@nongnu.org
Thanks to Peter for noticing that I forgot this.
Kevin
next prev parent reply other threads:[~2015-02-20 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 10:41 [Qemu-devel] [PATCH 0/3] coroutine: Fix qemu_coroutine_yield() Kevin Wolf
2015-02-10 10:41 ` [Qemu-devel] [PATCH 1/3] coroutine: Fix use after free with qemu_coroutine_yield() Kevin Wolf
2015-02-20 15:05 ` Kevin Wolf [this message]
2015-02-10 10:41 ` [Qemu-devel] [PATCH 2/3] coroutine: Clean up qemu_coroutine_enter() Kevin Wolf
2015-02-10 10:55 ` Paolo Bonzini
2015-02-10 11:09 ` Kevin Wolf
2015-02-10 11:15 ` Paolo Bonzini
2015-02-18 13:50 ` Stefan Hajnoczi
2015-02-18 14:20 ` Kevin Wolf
2015-02-19 14:33 ` Stefan Hajnoczi
2015-02-10 10:41 ` [Qemu-devel] [PATCH 3/3] test-coroutine: Regression test for yield bug Kevin Wolf
2015-02-16 10:19 ` [Qemu-devel] [PATCH 0/3] coroutine: Fix qemu_coroutine_yield() Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220150501.GE4464@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wu.wubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).