From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOp4k-000358-KZ
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:01:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOp4d-0003QW-H8
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:01:06 -0500
Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:33431)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOp4d-0003Pm-6H
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:00:59 -0500
Received: from /spool/local
	by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mimu@linux.vnet.ibm.com>;
	Fri, 20 Feb 2015 15:00:53 -0000
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 79C611B0805F
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 15:01:03 +0000 (GMT)
Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com
	[9.149.37.250])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t1KF0nZN10813828
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 15:00:50 GMT
Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t1KF0m9x004604
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 08:00:49 -0700
Date: Fri, 20 Feb 2015 16:00:46 +0100
From: Michael Mueller <mimu@linux.vnet.ibm.com>
Message-ID: <20150220160046.4743acc8@bee>
In-Reply-To: <54E73C8F.7000202@suse.de>
References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com>
	<1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com>
	<54E73C8F.7000202@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce
 S390 CPU models
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, Christian Borntraeger <borntraeger@de.ibm.com>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas Faerber <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Fri, 20 Feb 2015 14:54:23 +0100
Alexander Graf <agraf@suse.de> wrote:

> >  
> > +/* machine related properties */
> > +typedef struct S390CPUMachineProps {
> > +    uint16_t class;      /* machine class */
> > +    uint16_t ga;         /* availability number of machine */
> > +    uint16_t order;      /* order of availability */
> > +} S390CPUMachineProps;
> > +
> > +/* processor related properties */
> > +typedef struct S390CPUProcessorProps {
> > +    uint16_t gen;        /* S390 CMOS generation */
> > +    uint16_t ver;        /* version of processor */
> > +    uint32_t id;         /* processor identification*/
> > +    uint16_t type;       /* machine type */
> > +    uint16_t ibc;        /* IBC value */
> > +    uint64_t *fac_list;  /* list of facilities */  
> 
> Just make this uint64_t fac_list[2]. That way we don't have to track any
> messy allocations.

It will be something like "uint64_t fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB not
just 16 bytes but I will change it.