Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

[Michael Mueller <mimu@linux.vnet.ibm.com>]

On Fri, 20 Feb 2015 14:55:32 +0100
Alexander Graf <agraf@suse.de> wrote:

> >  /**
> >   * S390CPUClass:
> >   * @parent_realize: The parent class' realize handler.
> > @@ -52,6 +69,11 @@ typedef struct S390CPUClass {
> >      void (*load_normal)(CPUState *cpu);
> >      void (*cpu_reset)(CPUState *cpu);
> >      void (*initial_cpu_reset)(CPUState *cpu);
> > +    bool is_active[ACCEL_ID_MAX]; /* model enabled for given host and accel */
> > +    bool is_host[ACCEL_ID_MAX];   /* model markes host for given accel */
> > +    uint64_t *fac_list;           /* active facility list */
> > +    S390CPUMachineProps   *mach;  /* machine specific properties */
> > +    S390CPUProcessorProps *proc;  /* processor specific properties */  
> 
> Sorry, same here. Just put the structs straight into the class struct.

Yep, consistent.