From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58478)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOp69-00042A-7D
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:02:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOp66-0003s2-2Z
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:02:33 -0500
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:60511)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOp65-0003rx-Ox
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:02:30 -0500
Received: from /spool/local
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mimu@linux.vnet.ibm.com>;
	Fri, 20 Feb 2015 15:02:28 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id BD6E7219005E
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 15:02:19 +0000 (GMT)
Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com
	[9.149.37.228])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t1KF2Pcs10551604
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 15:02:25 GMT
Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t1KF2Ov5008508
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 08:02:25 -0700
Date: Fri, 20 Feb 2015 16:02:22 +0100
From: Michael Mueller <mimu@linux.vnet.ibm.com>
Message-ID: <20150220160222.4a7817d7@bee>
In-Reply-To: <54E73CD4.8080506@suse.de>
References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com>
	<1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com>
	<54E73CD4.8080506@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce
 S390 CPU models
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, Gleb Natapov <gleb@kernel.org>, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, Christian Borntraeger <borntraeger@de.ibm.com>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas Faerber <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Fri, 20 Feb 2015 14:55:32 +0100
Alexander Graf <agraf@suse.de> wrote:

> >  /**
> >   * S390CPUClass:
> >   * @parent_realize: The parent class' realize handler.
> > @@ -52,6 +69,11 @@ typedef struct S390CPUClass {
> >      void (*load_normal)(CPUState *cpu);
> >      void (*cpu_reset)(CPUState *cpu);
> >      void (*initial_cpu_reset)(CPUState *cpu);
> > +    bool is_active[ACCEL_ID_MAX]; /* model enabled for given host and accel */
> > +    bool is_host[ACCEL_ID_MAX];   /* model markes host for given accel */
> > +    uint64_t *fac_list;           /* active facility list */
> > +    S390CPUMachineProps   *mach;  /* machine specific properties */
> > +    S390CPUProcessorProps *proc;  /* processor specific properties */  
> 
> Sorry, same here. Just put the structs straight into the class struct.

Yep, consistent.