From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40372)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOpq6-0007hj-WC
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:50:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOpq3-0002Aq-Qq
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:50:02 -0500
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:45019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mimu@linux.vnet.ibm.com>) id 1YOpq3-0002Ah-HN
	for qemu-devel@nongnu.org; Fri, 20 Feb 2015 10:49:59 -0500
Received: from /spool/local
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mimu@linux.vnet.ibm.com>;
	Fri, 20 Feb 2015 15:49:57 -0000
Received: from b06cxnps4076.portsmouth.uk.ibm.com
	(d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1F71D219005C
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 15:49:48 +0000 (GMT)
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id t1KFnsxm64356578
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 15:49:54 GMT
Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id t1KFnq3C029543
	for <qemu-devel@nongnu.org>; Fri, 20 Feb 2015 08:49:53 -0700
Date: Fri, 20 Feb 2015 16:49:44 +0100
From: Michael Mueller <mimu@linux.vnet.ibm.com>
Message-ID: <20150220164944.4eb4eeb3@bee>
In-Reply-To: <89E3550E-9E2B-4D95-A809-B7C64EBCD7C5@suse.de>
References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com>
	<1424183053-4310-5-git-send-email-mimu@linux.vnet.ibm.com>
	<54E73C8F.7000202@suse.de> <20150220160046.4743acc8@bee>
	<89E3550E-9E2B-4D95-A809-B7C64EBCD7C5@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce
 S390 CPU models
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, Gleb Natapov <gleb@kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Christian Borntraeger <borntraeger@de.ibm.com>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas Faerber <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

On Fri, 20 Feb 2015 16:22:20 +0100
Alexander Graf <agraf@suse.de> wrote:

> >> 
> >> Just make this uint64_t fac_list[2]. That way we don't have to track any
> >> messy allocations.  
> > 
> > It will be something like "uint64_t fac_list[S390_CPU_FAC_LIST_SIZE_UINT64]" and in total 2KB
> > not just 16 bytes but I will change it.   
> 
> Why? Do we actually need that many? This is a qemu internal struct.

How do you know that 2 is a good size?

I want to have this independent from a future machine of the z/Arch. The kernel stores the full
facility set, KVM does and there is no good reason for QEMU not to do. If other accelerators
decide to just implement 64 or 128 bits of facilities that's ok...

Michael