From: David Gibson <david@gibson.dropbear.id.au>
To: Markus Armbruster <armbru@redhat.com>
Cc: David Gibson <dgibson@redhat.com>, Alexander Graf <agraf@suse.de>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 2/3] spapr: Clean up misuse of qdev_init() in xics-kvm creation
Date: Mon, 23 Feb 2015 11:31:48 +1100 [thread overview]
Message-ID: <20150223003148.GA4536@voom.redhat.com> (raw)
In-Reply-To: <87ioezz3ff.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Wed, Feb 18, 2015 at 03:42:44PM +0100, Markus Armbruster wrote:
> David, your commit 11ad93f suggests you're highly qualified to review.
> No good deed shall go unpunished ;)
Sorry, I somehow missed this one.
Reivewed-by: David Gibson <david@gibson.dropbear.id.au>
Though apparently Alex has merged it already, so I guess it's no
longer relevant.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-23 0:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 9:34 [Qemu-devel] [PATCH 0/3] Clean up misuse of qdev_init() in interrupt controller creation Markus Armbruster
2015-02-05 9:34 ` [Qemu-devel] [PATCH 1/3] PPC: Clean up misuse of qdev_init() in kvm-openpic creation Markus Armbruster
2015-02-18 14:43 ` Markus Armbruster
2015-02-25 0:04 ` Scott Wood
2015-02-25 9:32 ` Markus Armbruster
2015-02-05 9:34 ` [Qemu-devel] [PATCH 2/3] spapr: Clean up misuse of qdev_init() in xics-kvm creation Markus Armbruster
2015-02-18 14:42 ` Markus Armbruster
2015-02-23 0:31 ` David Gibson [this message]
2015-02-20 13:16 ` Alexander Graf
2015-02-05 9:34 ` [Qemu-devel] [PATCH 3/3] s390x: Replace unchecked qdev_init() by qdev_init_nofail() Markus Armbruster
2015-02-18 14:45 ` Markus Armbruster
2015-02-18 15:31 ` Cornelia Huck
2015-03-10 11:56 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223003148.GA4536@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=dgibson@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).