From: Amit Shah <amit.shah@redhat.com>
To: Yi Wang <up2wing@gmail.com>
Cc: kwolf@redhat.com, wang.yi59@zte.com.cn, qemu-devel@nongnu.org,
stefanha@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits
Date: Mon, 23 Feb 2015 16:08:33 +0530 [thread overview]
Message-ID: <20150223103833.GB22859@grmbl.mre> (raw)
In-Reply-To: <CAN35MuS=k1=GKqjCsTugVvYLgAErkV_s4T=H5F8q2qZ=KyNXaA@mail.gmail.com>
On (Mon) 12 Jan 2015 [01:12:41], Yi Wang wrote:
> From b119164ba6715f53594facfc4d1022c198852e9d Mon Sep 17 00:00:00 2001
> From: Yi Wang <up2wing@gmail.com>
> Date: Mon, 12 Jan 2015 00:05:40 +0800
> Subject: [PATCH] savevm: create snapshot failed when id_str already exits
>
> Create snapshot failed in this case:
> 1) vm has two or more qcow2 disks;
> 2) the first disk has snapshot with id_str 1, and the second disk has
> snapshots with id_str 2 and 3, for example;
> 3) create snapshot using virsh snapshot-create/snapshot-create-as will
> fail, 'cause id_str 2 has already existed in disk two.
>
> The reason is that do_savevm() didn't check id_str before create
> bdrv_snapshot_create(), and this patch fixed this.
>
> Signed-off-by: Yi Wang <up2wing@gmail.com>
I'll defer to the block people on this patch.
Amit
next prev parent reply other threads:[~2015-02-23 10:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 17:12 [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits Yi Wang
2015-02-23 10:38 ` Amit Shah [this message]
2015-02-25 9:41 ` Stefan Hajnoczi
2015-03-05 13:05 ` Yi Wang
2015-03-05 17:40 ` Stefan Hajnoczi
2015-03-06 14:35 ` Yi Wang
2015-03-06 15:50 ` Stefan Hajnoczi
2015-03-09 13:32 ` Yi Wang
2015-03-10 13:28 ` Stefan Hajnoczi
2015-03-10 13:48 ` Kevin Wolf
2015-03-11 12:57 ` Stefan Hajnoczi
2015-03-12 15:29 ` Yi Wang
2015-03-24 11:41 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223103833.GB22859@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=up2wing@gmail.com \
--cc=wang.yi59@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).