From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39308)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YPqPg-0003mT-8W
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 05:38:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YPqPb-0003RM-8v
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 05:38:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49297)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YPqPb-0003RD-1p
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 05:38:51 -0500
Date: Mon, 23 Feb 2015 16:08:33 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150223103833.GB22859@grmbl.mre>
References: <CAN35MuS=k1=GKqjCsTugVvYLgAErkV_s4T=H5F8q2qZ=KyNXaA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAN35MuS=k1=GKqjCsTugVvYLgAErkV_s4T=H5F8q2qZ=KyNXaA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str
 already exits
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yi Wang <up2wing@gmail.com>
Cc: kwolf@redhat.com, wang.yi59@zte.com.cn, qemu-devel@nongnu.org, stefanha@redhat.com, quintela@redhat.com

On (Mon) 12 Jan 2015 [01:12:41], Yi Wang wrote:
> From b119164ba6715f53594facfc4d1022c198852e9d Mon Sep 17 00:00:00 2001
> From: Yi Wang <up2wing@gmail.com>
> Date: Mon, 12 Jan 2015 00:05:40 +0800
> Subject: [PATCH] savevm: create snapshot failed when id_str already exits
> 
> Create snapshot failed in this case:
> 1) vm has two or more qcow2 disks;
> 2) the first disk has snapshot with id_str 1, and the second disk has
> snapshots with id_str 2 and 3, for example;
> 3) create snapshot using virsh snapshot-create/snapshot-create-as will
> fail, 'cause id_str 2 has already existed in disk two.
> 
> The reason is that do_savevm() didn't check id_str before create
> bdrv_snapshot_create(), and this patch fixed this.
> 
> Signed-off-by: Yi Wang <up2wing@gmail.com>

I'll defer to the block people on this patch.

		Amit