From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YPqgI-00050p-NK
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 05:56:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YPqgE-0000Mr-NX
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 05:56:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54297)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1YPqgE-0000MN-Fn
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 05:56:02 -0500
Date: Mon, 23 Feb 2015 10:55:53 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150223105553.GA2309@work-vm>
References: <1424346029-5410-1-git-send-email-dgilbert@redhat.com>
	<20150223103806.GC27533@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150223103806.GC27533@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] -incoming defer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: quintela@redhat.com, liang.z.li@intel.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com

* Stefan Hajnoczi (stefanha@gmail.com) wrote:
> On Thu, Feb 19, 2015 at 11:40:26AM +0000, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > This patchset provides a way of setting options on an incoming
> > migration before the fd/process/socket has been created.
> > 
> >    start qemu with   -incoming defer
> >    <use the monitor to set whatever you need>
> >    migrate_incoming theuri
> 
> Does this patch series break BDRV_O_INCOMING?
> 
> blockdev.c:blockdev_init():
>   if (runstate_check(RUN_STATE_INMIGRATE)) {
>       bdrv_flags |= BDRV_O_INCOMING;
>   }
> 
> The block layer needs to know about incoming migrations to avoid
> accessing or caching disk images while the source host still has them
> open.

No, it doesn't break it; it goes into RUN_STATE_INMIGRATE at startup
in the same way that all existing -incoming's do; the state transitions
should be identical.

Dave

> 
> Stefan


--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK