From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1YPtK0-00023p-Be
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 08:45:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1YPtJs-0005yO-J6
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 08:45:16 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rkrcmar@redhat.com>) id 1YPtJs-0005wf-C8
	for qemu-devel@nongnu.org; Mon, 23 Feb 2015 08:45:08 -0500
Date: Mon, 23 Feb 2015 14:45:02 +0100
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Message-ID: <20150223134501.GA2102@potion.brq.redhat.com>
References: <1424373859-2019-1-git-send-email-rkrcmar@redhat.com>
	<20150219203101.GA3974@potion.brq.redhat.com>
	<20150223104546.GE27533@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150223104546.GE27533@stefanha-thinkpad.redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] e1000: work around win 8.0 boot hang
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Wei Huang <wehuang@redhat.com>

2015-02-23 10:45+0000, Stefan Hajnoczi:
> On Thu, Feb 19, 2015 at 09:37:46PM +0100, Radim Kr=C4=8Dm=C3=A1=C5=99 w=
rote:
> > 2015-02-19 20:24+0100, Radim Kr=C4=8Dm=C3=A1=C5=99:
> > > diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> > > @@ -138,6 +138,10 @@ typedef struct E1000State_st {
> > > +#define E1000_WIN8_WORKAROUND_ICR       E1000_ICR_RXT0
> > > +#define E1000_WIN8_WORKAROUND_DELAY_US  10
> > > +    bool win8_workaround_needed;
> > > @@ -288,7 +292,7 @@ set_interrupt_cause(E1000State *s, int index, u=
int32_t val)
> > > @@ -316,13 +320,17 @@ set_interrupt_cause(E1000State *s, int index,=
 uint32_t val)
> > > +        if (s->win8_workround_needed) {
> >=20
> > So I read the patch again and noticed a typo here, which reminds me t=
hat
> > QEMU does not compile on rawhide for several reasons ...
> > I'll fix that to compensate.
>=20
> Just to clarify, you are NACKing this patch and will send a new series?

I would only change this line in v2 so far, so I wait for more comments
before respin.  It is possible that maintainers find fixing a typo
easier than handling v2, but it most likely is a NACK.

(The build fixes are already posted in an independent series, they were
 just a reason why I haven't even compile-tested this patch.)

> I want to make sure this fix doesn't get forgotten.

Thanks!