From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQ8D4-0005Vk-NM for qemu-devel@nongnu.org; Tue, 24 Feb 2015 00:39:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQ8Cp-0000iW-NH for qemu-devel@nongnu.org; Tue, 24 Feb 2015 00:39:06 -0500 Date: Tue, 24 Feb 2015 16:09:18 +1100 From: David Gibson Message-ID: <20150224050918.GK4536@voom.redhat.com> References: <1424680440-10913-1-git-send-email-aik@ozlabs.ru> <1424680440-10913-11-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4Djgzn3z2HSNnx0" Content-Disposition: inline In-Reply-To: <1424680440-10913-11-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH 10/10] spapr_iommu: Give unique QOM name to TCE table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --T4Djgzn3z2HSNnx0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2015 at 07:34:00PM +1100, Alexey Kardashevskiy wrote: > Useful for debugging. >=20 > Signed-off-by: Alexey Kardashevskiy Reviewed-by: David Gibson > --- > hw/ppc/spapr_iommu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index 65ee001..4f4836c 100644 > --- a/hw/ppc/spapr_iommu.c > +++ b/hw/ppc/spapr_iommu.c > @@ -160,6 +160,7 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *owner= , uint32_t liobn, > bool vfio_accel) > { > sPAPRTCETable *tcet; > + char tmp[64]; > =20 > if (spapr_tce_find_by_liobn(liobn)) { > fprintf(stderr, "Attempted to create TCE table with duplicate" > @@ -178,7 +179,8 @@ sPAPRTCETable *spapr_tce_new_table(DeviceState *owner= , uint32_t liobn, > tcet->nb_table =3D nb_table; > tcet->vfio_accel =3D vfio_accel; > =20 > - object_property_add_child(OBJECT(owner), "tce-table", OBJECT(tcet), = NULL); > + snprintf(tmp, sizeof(tmp), "tce-table-%x", liobn); > + object_property_add_child(OBJECT(owner), tmp, OBJECT(tcet), NULL); > =20 > object_property_set_bool(OBJECT(tcet), true, "realized", NULL); > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --T4Djgzn3z2HSNnx0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7Ad+AAoJEGw4ysog2bOS6nsQAIHaev1aGqC7IHNAj4vu1HIq IUlVk1Ccs3k1SXC50uoF8bZ974Bjz2BeEX8Ydqc6cAoYgrECjvL+Qg5PQAYywd6T SnKlYzFEVM8tKkQsiTjXcVtlHbdkZm6yxWcCc/iBhkT3d3DSvUOmDnvx2mZuHOkZ UO1lVD77MzUACpK9l594OWR4gHDL4RboH7xatxhvFkaToA/0h/SA7XlvDULvBtyW 1OJwgjJRk9GOSwQfHFwombv4E+mELGFkj8u8C0w+2WIff4qb5K+9WrUjZj8itPu+ /+CyKms5UYuIzxu+0x3ClJF12gQ/BxtWB8p+N5BQGoPJILWkb6HW/lvW+SFczHU8 j/qkjbMHK5seNYQSYh0wjS+7UV3P/kZp02OjBNt6do7eM69URmd5X2Ly5SkbjKT8 GhCG6F1zxdWlVqwTMqS3D1OxkLo4u9D+L2Mj6up3GoLRlI5JJ1Vg3ADRA+b4kTFU SuoXXyRaBsX27rjf9q9n/F72LzUxYpxgKt8fF53MsTBn2hogOGZpq9bddg61F6rU CBqXQ5+rybyVzhXh7CUAPDiVKhq6Do1mzfWNaI0cmKn8ujdo5muK12zS2yGWZI5M G8wMMmHJVhBwQRE6dV438CAlGi9r0dgAQtruTzvcb0MNmuF70sl772IDqVzYHqHv TBFLhJmFld40M3qhVqB1 =bSpV -----END PGP SIGNATURE----- --T4Djgzn3z2HSNnx0--