From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQ8Ct-0005Mg-SV for qemu-devel@nongnu.org; Tue, 24 Feb 2015 00:38:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQ8Cp-0000iF-M5 for qemu-devel@nongnu.org; Tue, 24 Feb 2015 00:38:55 -0500 Date: Tue, 24 Feb 2015 16:11:30 +1100 From: David Gibson Message-ID: <20150224051130.GL4536@voom.redhat.com> References: <1424680440-10913-1-git-send-email-aik@ozlabs.ru> <1424680440-10913-7-git-send-email-aik@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f54savKjS/tSNRaU" Content-Disposition: inline In-Reply-To: <1424680440-10913-7-git-send-email-aik@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH 06/10] spapr_iommu: Add separate trace points for PCI DMA operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf --f54savKjS/tSNRaU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2015 at 07:33:56PM +1100, Alexey Kardashevskiy wrote: > This is to reduce VIO noise while debugging PCI DMA. >=20 > Signed-off-by: Alexey Kardashevskiy So, in terms of mechanical correctness: Reviewed-by: David Gibson I see the rationale, but the idea of conditional tracepoints seems a bit icky to me. Don't know if the trace infrastructure people would have any opinion on this. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --f54savKjS/tSNRaU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7AgCAAoJEGw4ysog2bOSWY4P/ilDHNCRoYS/CdOt9oAe9L51 3QokkfhmFEd4crek4Z+Zh/Usi9pWaKUq9JvYLU4qbRw6g5zKDX2sVxLmZ03djHgN Nqp3vhoypWWPpHmaRcA6uHIt04R3affm0l2hruDzV9SLKgLpAdmRxqAkpSbxb4gk qsKbzRLK9pl71DeTyptmQBPiQ9FB0B+Jd31F/2PGNHQvX+gtlgfcA6rm/M+iCDsS V0abdMJl3mWPG/L58XPHd0Y34ibRw2kdzJBnuyWhu2/Nk9fkc4owJw3PcTadlAtA a7oQIA4GTV8joeXQgH0M9ymnvG0bRJKV1v/maTKdTfULNCpxcSrHFtC5013kl8xZ w9gWPx7JFUHCERQmo4yopwQZ4YKwcTfitJrGRPd/AgHDLNB3geXWkWAFocEcmcXr Aj0JSI4ak/3AmIi6+BUHE9Y+h/02tu5aZXm4Z8nBA6xvTKKkq5KPx8tYVRwzA7ls ESdEOFOU4y3OAHuU/iTbMnG/t0FRAkCMSZUct+dQHi8XtZY5xsOhJ+ytLc558psy GBXTVspqY2GZjybWZdg9ECIELCRIdGK4CeoIUnl3dVQTYVylYETz7u8Y6gVsoS3i GOeBUmfeB6bkDQ926aBrZoZUk+IFXv7LKwPMGUcdfIl1meXneAGF4qkVncpiyOKw 0AMs442vJFEGIurDR7ZU =8Gd/ -----END PGP SIGNATURE----- --f54savKjS/tSNRaU--