[Qemu-devel] [PATCH] qmp-commands.hx: Fix several typos

[Qemu-devel] [PATCH] qmp-commands.hx: Fix several typos

[Alberto Garcia]

Signed-off-by: Alberto Garcia <berto@igalia.com>
---
 qmp-commands.hx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/qmp-commands.hx b/qmp-commands.hx
index a85d847..52741ed 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1,5 +1,5 @@
 HXCOMM QMP dispatch table and documentation
-HXCOMM Text between SQMP and EQMP is copied to the QMP documention file and
+HXCOMM Text between SQMP and EQMP is copied to the QMP documentation file and
 HXCOMM does not show up in the other formats.
 
 SQMP
@@ -1767,7 +1767,7 @@ Arguments:
 
 - "protocol": protocol name (json-string)
 - "password": password (json-string)
-- "connected": [ keep | disconnect | fail ] (josn-string, optional)
+- "connected": [ keep | disconnect | fail ] (json-string, optional)
 
 Example:
 
@@ -2922,7 +2922,7 @@ Channels are described by a json-object, each one contain the following:
 - "channel-id": channel id.  Usually "0", might be different needed when
                 multiple channels of the same type exist, such as multiple
                 display channels in a multihead setup (json-int)
-- "tls": whevener the channel is encrypted (json-bool)
+- "tls": whenever the channel is encrypted (json-bool)
 
 Example:
 
-- 
2.1.4

Re: [Qemu-devel] [PATCH] qmp-commands.hx: Fix several typos

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

On 02/23/2015 01:27 PM, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  qmp-commands.hx | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

> @@ -2922,7 +2922,7 @@ Channels are described by a json-object, each one contain the following:
>  - "channel-id": channel id.  Usually "0", might be different needed when
>                  multiple channels of the same type exist, such as multiple
>                  display channels in a multihead setup (json-int)
> -- "tls": whevener the channel is encrypted (json-bool)
> +- "tls": whenever the channel is encrypted (json-bool)

Might be nicer as 'whether' rather than 'whenever'.

But as your version is strictly better than an obvious typo,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [PATCH] qmp-commands.hx: Fix several typos

[Alberto Garcia]

On Mon, Feb 23, 2015 at 02:26:28PM -0700, Eric Blake wrote:

> > -- "tls": whevener the channel is encrypted (json-bool)
> > +- "tls": whenever the channel is encrypted (json-bool)
> 
> Might be nicer as 'whether' rather than 'whenever'.

Oh, you're right. Feel free to change it, or do you want me to
resubmit the patch?

Berto

Re: [Qemu-devel] [PATCH] qmp-commands.hx: Fix several typos

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On 02/24/2015 12:01 AM, Alberto Garcia wrote:
> On Mon, Feb 23, 2015 at 02:26:28PM -0700, Eric Blake wrote:
> 
>>> -- "tls": whevener the channel is encrypted (json-bool)
>>> +- "tls": whenever the channel is encrypted (json-bool)
>>
>> Might be nicer as 'whether' rather than 'whenever'.
> 
> Oh, you're right. Feel free to change it, or do you want me to
> resubmit the patch?

Up to the trivial tree maintainer, but if it were me, I'd resend a v2 to
make his life easier.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]