From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1YQ9JS-0007qk-K6
	for qemu-devel@nongnu.org; Tue, 24 Feb 2015 01:49:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1YQ9JP-0006Zn-Cy
	for qemu-devel@nongnu.org; Tue, 24 Feb 2015 01:49:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41452)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1YQ9JP-0006ZZ-5I
	for qemu-devel@nongnu.org; Tue, 24 Feb 2015 01:49:43 -0500
Date: Tue, 24 Feb 2015 07:49:36 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20150224074936.3be3b13f@nial.brq.redhat.com>
In-Reply-To: <1423763435-3696-3-git-send-email-ehabkost@redhat.com>
References: <1423763435-3696-1-git-send-email-ehabkost@redhat.com>
	<1423763435-3696-3-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/4] numa: Reject CPU indexes > max_cpus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, 12 Feb 2015 15:50:33 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:

> CPU index is always less than max_cpus, as documented at sysemu.h:
> 
> > The following shall be true for all CPUs:
> >   cpu->cpu_index < max_cpus <= MAX_CPUMASK_BITS
> 
> Reject configuration which uses invalid CPU indexes.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Excluding nitpicking below
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
> v1 -> v2: (no changes)
> 
> v2 -> v3:
>  * Check for (cpu >= max_cpus) instead of (cpu > max_cpus)
>  * Reword error message as we are not checking for "bigger than maxcpus"
>    CPU indexes
> ---
>  numa.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/numa.c b/numa.c
> index 41e496b..4139e46 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -76,9 +76,11 @@ static void numa_node_parse(NumaNodeOptions *node, QemuOpts *opts, Error **errp)
>      }
>  
>      for (cpus = node->cpus; cpus; cpus = cpus->next) {
> -        if (cpus->value >= MAX_CPUMASK_BITS) {
> -            error_setg(errp, "CPU number %" PRIu16 " is bigger than %d",
> -                       cpus->value, MAX_CPUMASK_BITS - 1);
> +        if (cpus->value >= max_cpus) {
> +            error_setg(errp,
> +                       "CPU index (%" PRIu16 ")" \
'\' is not really necessary here

> +                       " should be smaller than maxcpus (%d)",
> +                       cpus->value, max_cpus);
>              return;
>          }
>          bitmap_set(numa_info[nodenr].node_cpu, cpus->value, 1);