From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQBlW-0006D2-Jq for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:26:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQBlR-0006h5-6p for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:26:54 -0500 Date: Tue, 24 Feb 2015 20:11:01 +1100 From: David Gibson Message-ID: <20150224091101.GV4536@voom.redhat.com> References: <1424096872-29868-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424096872-29868-10-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jfWagoTHmfL/c8Ax" Content-Disposition: inline In-Reply-To: <1424096872-29868-10-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v5 09/16] spapr_events: event-scan RTAS interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --jfWagoTHmfL/c8Ax Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 16, 2015 at 08:27:45AM -0600, Michael Roth wrote: > From: Tyrel Datwyler >=20 > We don't actually rely on this interface to surface hotplug events, and > instead rely on the similar-but-interrupt-driven check-exception RTAS > interface used for EPOW events. However, the existence of this interface > is needed to ensure guest kernels initialize the event-reporting > interfaces which will in turn be used by userspace tools to handle these > events, so we implement this interface here. >=20 > Since events surfaced by this call are mutually exclusive to those > surfaced via check-exception, we also update the RTAS event queue code > to accept a boolean to mark/filter for events accordingly. >=20 > Events of this sort are not currently generated by QEMU, but the interface > has been tested by surfacing hotplug events via event-scan in place > of check-exception. >=20 > Signed-off-by: Tyrel Datwyler > Signed-off-by: Michael Roth Hrm, seems a little odd to implement a queue which nothing will put events into, but it looks correct. Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --jfWagoTHmfL/c8Ax Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7EAlAAoJEGw4ysog2bOSbfgP/2xUu/EdIa6c8dXhSlBXy+1E bE5qLYh2MtSC5ONZYKqY48AQjAAwgVXe2XtRUjNWX4MRVJG7J+kL+O5emGBekKdU APWwhymBBqB4f/rfyAyGgvvqf3BZFqMezoIAauiRV0hPp0NFehaJDZrxS/0exNPw llhAiqsep8cR6SF6rnkziXlJIWR2cStsHfzr5ddkjiA0VB2NNl3T/ETJ9V5xzZtM GBqZtsXcW+YzUORmfieGzWkSEy1JpLVXeXwtj3Lip3DJkdBhwPokas5cKY1L4HQF B4KQ3BqWVFa0M1cIbsjxLnyK8zCke/4WJKkT79ZcerlRNo9NY4lrqXC7wa0KaNz+ QXtmy1hLbsjI+ABNXlS/F16dkS8di9Scx7WL/4hHJuuNzlTcmuOp2+eYs6dCCq0j 3jXJiBZijgEQc53LaLa9ZqeCjQUSje+DYZToqePNJvwjtaoswUjQamnqRSQt2It0 LNWA1qysbyGAM17v7jCt8s7HVNlDT3xaiDJKgslIxMsi6h0tKo+kJTeC79wLiEM/ eLfEs9CS2WAyXDbs7l+zmHTSkwZsuehWcTREAKbdlBXmrs2aZyk9TC42b1RzGI6m rfG9rVM6E+MthAmAte1Jlu16216/glaiXo/EAMeT3MOZvEiyb7Ws5fCQSvkN0TDZ uUncUVZ8K0c8mcZq8p7e =MsRs -----END PGP SIGNATURE----- --jfWagoTHmfL/c8Ax--