From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54435)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YQBnR-0000BI-0M
	for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:28:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1YQBnQ-0007S4-4K
	for qemu-devel@nongnu.org; Tue, 24 Feb 2015 04:28:52 -0500
Date: Tue, 24 Feb 2015 14:58:29 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20150224092829.GA26558@grmbl.mre>
References: <1424365943-27563-1-git-send-email-thuth@linux.vnet.ibm.com>
	<1424365943-27563-2-git-send-email-thuth@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1424365943-27563-2-git-send-email-thuth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1/5] migration: Remove unused functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On (Thu) 19 Feb 2015 [18:12:19], Thomas Huth wrote:
> dup_mig_bytes_transferred(), skipped_mig_bytes_transferred(),
> migrate_rdma_pin_all(), qsb_clone() and qsb_set_length()
> are completely unused and thus can be deleted.
> 
> Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: Amit Shah <amit.shah@redhat.com>
> ---
>  arch_init.c                   |   10 -------
>  include/migration/migration.h |    3 --
>  include/migration/qemu-file.h |    2 -
>  migration/migration.c         |    9 -------
>  migration/qemu-file-buf.c     |   53 -----------------------------------------
>  5 files changed, 0 insertions(+), 77 deletions(-)
> 
> diff --git a/arch_init.c b/arch_init.c
> index 89c8fa4..ad5ce28 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -249,21 +249,11 @@ static void acct_clear(void)
>      memset(&acct_info, 0, sizeof(acct_info));
>  }
>  
> -uint64_t dup_mig_bytes_transferred(void)
> -{
> -    return acct_info.dup_pages * TARGET_PAGE_SIZE;
> -}
> -
>  uint64_t dup_mig_pages_transferred(void)
>  {
>      return acct_info.dup_pages;
>  }
>  
> -uint64_t skipped_mig_bytes_transferred(void)
> -{
> -    return acct_info.skipped_pages * TARGET_PAGE_SIZE;
> -}

These could be used for reporting; Juan, any idea why these aren't
used?

Rest of the patch is fine.

		Amit