From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQCN4-0008Ur-Oc for qemu-devel@nongnu.org; Tue, 24 Feb 2015 05:05:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQCN3-0002UO-F7 for qemu-devel@nongnu.org; Tue, 24 Feb 2015 05:05:42 -0500 Date: Tue, 24 Feb 2015 20:29:40 +1100 From: David Gibson Message-ID: <20150224092940.GX4536@voom.redhat.com> References: <1424096872-29868-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424096872-29868-14-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uWCTLymdFNG0vGYZ" Content-Disposition: inline In-Reply-To: <1424096872-29868-14-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for PHBs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --uWCTLymdFNG0vGYZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 16, 2015 at 08:27:49AM -0600, Michael Roth wrote: > Reserve 32 entries of type PCI in each PHB's initial FDT. This I find this description odd. It's not reallky reserving anything, just publishing the DRCs you already created in the FDT. I wonder if this should be merged with the previous patch. > advertises to guests that each PHB is DR-capable device with > physical hotpluggable slots. This is necessary for allowing > hotplugging of devices to it later via bus rescan or guest rpaphp > hotplug module. >=20 > Signed-off-by: Michael Roth But, it looks correct. Reviewed-by: David Gibson --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --uWCTLymdFNG0vGYZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7ESEAAoJEGw4ysog2bOSStwQAJbi+bOH1l8o6Uu7Jupls8Cj 2th6lkhAIWPO4P3B1tEpuevfTiYRSzbvrtLtKmtm+XM0kAdFAWyzy1M4oA2AUgQV psb08bhCVLt9Gj1ygO6y3MORusQo0Xd+HoS7pdC5IY/ffITmlDmFd8jC6pWdiIbg IHzdJTC4UjRglTNiRO5UaAXELVxKj9XhnrjTHxTc7BIIbTyFrPELM6STF732VHQf 5EitCm4+ryc1go7LipkXip21oOjBLlB4+CDibWydNzJ9mygvigHDpei5s4hXi6YT 1UkRbczqjScmu7JCs+5SK9LW8DTWEhwU/hMjivxWnZgKcaEkhIgwJgSIKgD+rO/y HKg0AB6dyBez3FAH1tJzhnUtvJsQuebHO/DwE9b9QvF/IYOe8vo7ZqazvL4/elgU tytBXrGmoT6F++Npz1hm3NyxZAuWp/i+PZbd2EULcnsyqCD54Ja+kbqp3ErgcSZk NHeZqEwQN0KKn6E9YvcXrRdc60iDy1jNk4jB6NsptyMZs++lcIhu/caYZYii7Whi DiwrEDsrgYNo5NGDCDgHKVy9C28bt4mJpfaQz/EAxRv9ZvKDp3uc3+VgLrpfPgIo 66bMEz9N41/vMM8EOI9T/MhQ7LLZkb/a8k9fR1/DaUjtJ8d505PzBzK9MWBmFiEF IgN7zxPdX4OYQCYVM/hp =T4Ma -----END PGP SIGNATURE----- --uWCTLymdFNG0vGYZ--