From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQClO-0005Sn-SH for qemu-devel@nongnu.org; Tue, 24 Feb 2015 05:30:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQClL-0002di-Mf for qemu-devel@nongnu.org; Tue, 24 Feb 2015 05:30:50 -0500 Date: Tue, 24 Feb 2015 21:20:40 +1100 From: David Gibson Message-ID: <20150224102040.GY4536@voom.redhat.com> References: <1424096872-29868-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424096872-29868-15-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Zzd9Wh/bp6DhMAqJ" Content-Disposition: inline In-Reply-To: <1424096872-29868-15-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v5 14/16] pci: make pci_bar useable outside pci.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: mst@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --Zzd9Wh/bp6DhMAqJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 16, 2015 at 08:27:50AM -0600, Michael Roth wrote: > We need to work with PCI BARs to generate OF properties > during PCI hotplug for sPAPR guests. >=20 > Signed-off-by: Michael Roth Added Michael Tsirkin to the Cc list, since he usually handles the PCI subsystem. Reviewed-by: David Gibson > --- > hw/pci/pci.c | 2 +- > include/hw/pci/pci.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/pci/pci.c b/hw/pci/pci.c > index d508930..f37d3e1 100644 > --- a/hw/pci/pci.c > +++ b/hw/pci/pci.c > @@ -123,7 +123,7 @@ static uint16_t pci_default_sub_device_id =3D PCI_SUB= DEVICE_ID_QEMU; > =20 > static QLIST_HEAD(, PCIHostState) pci_host_bridges; > =20 > -static int pci_bar(PCIDevice *d, int reg) > +int pci_bar(PCIDevice *d, int reg) > { > uint8_t type; > =20 > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index 97a83d3..eba9200 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -330,6 +330,7 @@ void pci_device_save(PCIDevice *s, QEMUFile *f); > int pci_device_load(PCIDevice *s, QEMUFile *f); > MemoryRegion *pci_address_space(PCIDevice *dev); > MemoryRegion *pci_address_space_io(PCIDevice *dev); > +int pci_bar(PCIDevice *d, int reg); > =20 > typedef void (*pci_set_irq_fn)(void *opaque, int irq_num, int level); > typedef int (*pci_map_irq_fn)(PCIDevice *pci_dev, int irq_num); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Zzd9Wh/bp6DhMAqJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7FB4AAoJEGw4ysog2bOSSagP/AlrR9pZXAHY/mNr+zZnSqzn bqms6yW7ELHJQCRZp64Rwb+EJ6k3QAEQzJ8Hcm5IgRO1OU200fMp9m2m/2ymYe/f m2NKzKDXjLtt7Xg95VVr1040vBbMLVkvZpTbbKDE4ilrBZ5s0rk2UM0pOMh8i0eO /8G1mGa3LDaMdls7tEU/Utdc/VqN5ic2zxaBwhvTrTbKt52NnNIjmYtBiLwQhLPp wyA902Chkw9S1T54PTirwLbAFMRNmFzUcQi2Ijj8qOhetz8O+tYH77qFlFjiUnRW hNty4i8URUmjIYQ6u3gtrcPsR7A5sJ/sUMD70teEGna0U/HXJWpwfSzR6hw9l8Pw o9PCgfeZfkuie0p4dsROLVXGGyRIdHJM2z28mEO1k0yMmDN9t700VrcOMggGmIH7 PQ3UdXr7b0kpN6+R14Vy7xC8mXpMFy+KDk8/gAS+kf9DuRk7GjthkICbFiGFb4Uc zPS+sB75QuX7Z7p8vIzczlMI0SQRax/TagFjJgAIEGKJR/W7Hgb18wZpCH/en5/m r590l+T00ac0ry6ai71CZERztkNPPsnq2z3cysQwh7KQYeZguzg7s7gNQciYJKP1 niI8fJS/9o5x7colc0DO86U18Z59sY1CuqjUfiEpkIPYVTIE9mhlOXNommRkRL+8 cOgwMVradHofFhayvwaR =98U7 -----END PGP SIGNATURE----- --Zzd9Wh/bp6DhMAqJ--