From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQDFQ-0005ug-Vm for qemu-devel@nongnu.org; Tue, 24 Feb 2015 06:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQDFM-0005rL-02 for qemu-devel@nongnu.org; Tue, 24 Feb 2015 06:01:52 -0500 Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:33491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQDFL-0005r5-Ph for qemu-devel@nongnu.org; Tue, 24 Feb 2015 06:01:47 -0500 Received: by wevk48 with SMTP id k48so24427523wev.0 for ; Tue, 24 Feb 2015 03:01:46 -0800 (PST) Date: Tue, 24 Feb 2015 11:01:43 +0000 From: Stefan Hajnoczi Message-ID: <20150224110143.GA29466@stefanha-thinkpad.redhat.com> References: <1424346029-5410-1-git-send-email-dgilbert@redhat.com> <20150223103806.GC27533@stefanha-thinkpad.redhat.com> <20150223105553.GA2309@work-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF" Content-Disposition: inline In-Reply-To: <20150223105553.GA2309@work-vm> Subject: Re: [Qemu-devel] [PATCH v3 0/3] -incoming defer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: quintela@redhat.com, liang.z.li@intel.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com --h31gzZEtNLTqOjlF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2015 at 10:55:53AM +0000, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefanha@gmail.com) wrote: > > On Thu, Feb 19, 2015 at 11:40:26AM +0000, Dr. David Alan Gilbert (git) = wrote: > > > From: "Dr. David Alan Gilbert" > > >=20 > > > This patchset provides a way of setting options on an incoming > > > migration before the fd/process/socket has been created. > > >=20 > > > start qemu with -incoming defer > > > > > > migrate_incoming theuri > >=20 > > Does this patch series break BDRV_O_INCOMING? > >=20 > > blockdev.c:blockdev_init(): > > if (runstate_check(RUN_STATE_INMIGRATE)) { > > bdrv_flags |=3D BDRV_O_INCOMING; > > } > >=20 > > The block layer needs to know about incoming migrations to avoid > > accessing or caching disk images while the source host still has them > > open. >=20 > No, it doesn't break it; it goes into RUN_STATE_INMIGRATE at startup > in the same way that all existing -incoming's do; the state transitions > should be identical. Great, thanks for explaining. I have verified that vl.c:main() sets RUN_STATE_INMIGRATE in all cases: case QEMU_OPTION_incoming: incoming =3D optarg; runstate_set(RUN_STATE_INMIGRATE); break; Stefan --h31gzZEtNLTqOjlF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU7FoXAAoJEJykq7OBq3PI6egIAJcVPL1Jh4bD9WIv1yn5C+ve 3L1cKf0Z6rcyY4D8JSpI/rzPykmCfIaubr96Kbtpv5FC1zBW8NpJs0yVyQ11NF0c Xezh+652d3du0mC3sdCbSj7azxz/Z2+4H5MflmwGpgnFUdym0IPA+V8NlAaDajkj SptKk6wldYld/zyvrjDVMa+9SqbbD+T/NyCJcZNFkOBrR8kTiNdSAvk+C4YuJjLP JrHOccQn3Hp94Q9lpNFsX4JhqD7ltqoukXcmn/JGbDZ4DO3cuWH1g26/m8S8U1e7 GSrRfs0TIhtFj9IGbfaOWawj8lblmDaSpBJ8mHpnjWrwcPDh21KlUoElzCUzl7M= =z+Nn -----END PGP SIGNATURE----- --h31gzZEtNLTqOjlF--