From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQEv7-00024A-S1 for qemu-devel@nongnu.org; Tue, 24 Feb 2015 07:49:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQEv3-0001xD-Tl for qemu-devel@nongnu.org; Tue, 24 Feb 2015 07:49:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQEv3-0001x7-Me for qemu-devel@nongnu.org; Tue, 24 Feb 2015 07:48:57 -0500 Date: Tue, 24 Feb 2015 18:18:41 +0530 From: Amit Shah Message-ID: <20150224124841.GE26558@grmbl.mre> References: <1423778591-12590-1-git-send-email-quintela@redhat.com> <1423778591-12590-7-git-send-email-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423778591-12590-7-git-send-email-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 6/6] rename save_block_hdr to save_page_header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: liang.z.li@intel.com, qemu-devel@nongnu.org On (Thu) 12 Feb 2015 [23:03:11], Juan Quintela wrote: > It has always been a page header, not a block header. Once there, the > flag argument was only passed to make a bit or with it, just do the or > on the caller. I prefer not to do that -- if one looks at the function signature, he'll only notice 'offset' there and not 'offset|flag', so it's confusing to callers of function why the | is being done for an offset field. Let's keep that bit as-is? Amit