From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQKan-0005fK-Ir for qemu-devel@nongnu.org; Tue, 24 Feb 2015 13:52:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQKak-0006pT-7m for qemu-devel@nongnu.org; Tue, 24 Feb 2015 13:52:25 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:54529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQKak-0006pG-2A for qemu-devel@nongnu.org; Tue, 24 Feb 2015 13:52:22 -0500 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Feb 2015 13:52:19 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <20150224092940.GX4536@voom.redhat.com> References: <1424096872-29868-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424096872-29868-14-git-send-email-mdroth@linux.vnet.ibm.com> <20150224092940.GX4536@voom.redhat.com> Message-ID: <20150224185210.31752.7893@loki> Date: Tue, 24 Feb 2015 12:52:10 -0600 Subject: Re: [Qemu-devel] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for PHBs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com Quoting David Gibson (2015-02-24 03:29:40) > On Mon, Feb 16, 2015 at 08:27:49AM -0600, Michael Roth wrote: > > Reserve 32 entries of type PCI in each PHB's initial FDT. This > = > I find this description odd. It's not reallky reserving anything, > just publishing the DRCs you already created in the FDT. Yah, I think this is an artifact from earlier versions where we reserved the entries statically. > = > I wonder if this should be merged with the previous patch. Makes sense. Will fix up the description and merge this into previous patch. > = > > advertises to guests that each PHB is DR-capable device with > > physical hotpluggable slots. This is necessary for allowing > > hotplugging of devices to it later via bus rescan or guest rpaphp > > hotplug module. > > = > > Signed-off-by: Michael Roth > = > But, it looks correct. > = > Reviewed-by: David Gibson > = > -- = > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _othe= r_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson