From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQQxM-00011w-UN for qemu-devel@nongnu.org; Tue, 24 Feb 2015 20:40:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQQxH-0006zF-9t for qemu-devel@nongnu.org; Tue, 24 Feb 2015 20:40:08 -0500 Received: from mail-ig0-x22f.google.com ([2607:f8b0:4001:c05::22f]:40793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQQxH-0006v1-2P for qemu-devel@nongnu.org; Tue, 24 Feb 2015 20:40:03 -0500 Received: by mail-ig0-f175.google.com with SMTP id hn18so31811485igb.2 for ; Tue, 24 Feb 2015 17:40:01 -0800 (PST) Date: Wed, 25 Feb 2015 09:39:53 +0800 From: Liu Yuan Message-ID: <20150225013953.GB6415@ubuntu-trusty> References: <87pp9f1b61.fsf@blackfin.pond.sub.org> <1423799142-21893-1-git-send-email-namei.unix@gmail.com> <87egpn7h38.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87egpn7h38.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: sheepdog@lists.wpkg.org, qemu-devel@nongnu.org On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote: > Liu Yuan writes: > > > From: Liu Yuan > > > > These functions mix up -1 and -errno in return values and would might cause > > trouble error handling in the call chain. > > > > This patch let them return -errno and add some comments. > > > > Reported-by: Markus Armbruster > > Signed-off-by: Liu Yuan > > Did you review all functions returning negative errno, or just the two > that caught my eye? Umm, mostly the two you mentioned. Yuan