From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQSZY-0000G3-LD for qemu-devel@nongnu.org; Tue, 24 Feb 2015 22:23:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQSZX-0004nL-Mz for qemu-devel@nongnu.org; Tue, 24 Feb 2015 22:23:40 -0500 Date: Wed, 25 Feb 2015 14:18:58 +1100 From: David Gibson Message-ID: <20150225031858.GE15695@voom.fritz.box> References: <1424096872-29868-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424096872-29868-17-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lteA1dqeVaWQ9QQl" Content-Disposition: inline In-Reply-To: <1424096872-29868-17-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v5 16/16] spapr_pci: emit hotplug add/remove events during hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --lteA1dqeVaWQ9QQl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 16, 2015 at 08:27:52AM -0600, Michael Roth wrote: > From: Tyrel Datwyler >=20 > This uses extension of existing EPOW interrupt/event mechanism > to notify userspace tools like librtas/drmgr to handle > in-guest configuration/cleanup operations in response to > device_add/device_del. >=20 > Userspace tools that don't implement this extension will need > to be run manually in response/advance of device_add/device_del, > respectively. >=20 > Signed-off-by: Tyrel Datwyler > Signed-off-by: Michael Roth Reviewed-by: David Gibson > --- > hw/ppc/spapr_pci.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index b9af1cd..7713bfb 100644 > --- a/hw/ppc/spapr_pci.c > +++ b/hw/ppc/spapr_pci.c > @@ -810,6 +810,9 @@ static void spapr_phb_hot_plug_child(HotplugHandler *= plug_handler, > error_propagate(errp, local_err); > return; > } > + if (plugged_dev->hotplugged) { > + spapr_hotplug_req_add_event(drc); > + } > } > =20 > static void spapr_phb_hot_unplug_child(HotplugHandler *plug_handler, > @@ -840,6 +843,7 @@ static void spapr_phb_hot_unplug_child(HotplugHandler= *plug_handler, > error_propagate(errp, local_err); > return; > } > + spapr_hotplug_req_remove_event(drc); > } > } > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --lteA1dqeVaWQ9QQl Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU7T8iAAoJEGw4ysog2bOSr9cP/3b6XRg/C/rtsi87c6FfjbQj q3kxF6b+1xCpQVLLCpKLf70mwU5I7Y4tDi11OuC2QAMsmcBm2/YhZvFmWUhvvfFI L8Ir5I1LKlWf7AyofqnbJTDIKRFMfxnxyvIRkNy8bDrEMiGWwqUWJUZXHHYjPIiM mc7lcJMWre8WGP/I/JLjpZnDDh3qd8iI1EAGI6U844PlPoQq0kW3U0DQDc2rBP6I GnLJVvVARpgI4akBnuGMMh81TzPUGAhQQBLxuj5isSfYHFc4b643W+uaa3ji3l/s aL7duSUHlqAW3cvis/pEKGMP+r7R2wJVkf5JfIn0VZMI8cbkLfVPB932ThFiNU+A HowNgrdEgKulch2UCKUHZLc9I2fHBD1IG0ZSmj2LvHP5qIJqaVwG3irChxEpqCrH qu7mWM+LuA+8F7FNYvDuqT7/0dOJlthnmI2a7ACBpyq5vGnPjBh/frLQv5wW5Y18 iU2XQYQCqkWAtvlDVAAOipIXABcHdDDz5/shpOzjrczkaL70Zn6ZeAaLmP8dg3o6 Egu2pLUxOi7/zTVYLNPQQ2WLk9YUDmnm1AggIL2A0kPGdl2SFY42yh0G3acbcUYH z7zD7EBisuMmtB0eXVwzDcSY/YtJ2ij1x/SrnE7ZSPMB8KrtUnNqHJYp789KM7kw 6TXOc46jIvbY3dZLlaCp =ptiQ -----END PGP SIGNATURE----- --lteA1dqeVaWQ9QQl--