From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YQVZK-0006L0-6G
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 01:35:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YQVZI-0002dQ-S3
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 01:35:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55117)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1YQVZI-0002dI-HZ
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 01:35:36 -0500
Date: Wed, 25 Feb 2015 14:35:29 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20150225063529.GD5293@ad.nay.redhat.com>
References: <1424332114-13440-1-git-send-email-mst@redhat.com>
	<1424332114-13440-2-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1424332114-13440-2-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] Makefile.target: binary depends on
	config-devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: peter.maydell@linaro.org, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org, blauwirbel@gmail.com, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, =?us-ascii?B?PT9VVEYtOD9xP0xsdT1DMz1BRHM9MjBWaWxhbm92YT89?= <vilanova@ac.upc.edu>

On Thu, 02/19 08:48, Michael S. Tsirkin wrote:
> relink binary whenever config-devices.mak changes:
> this makes sense as we are adding/removing devices,
> so binary has to be relinked to be up to date.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  Makefile.target | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.target b/Makefile.target
> index 58c6ae1..2262d89 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -175,9 +175,11 @@ all-obj-y += $(common-obj-y)
>  all-obj-y += $(target-obj-y)
>  all-obj-$(CONFIG_SOFTMMU) += $(block-obj-y)
>  
> +$(QEMU_PROG_BUILD): config-devices.mak
> +
>  # build either PROG or PROGW
>  $(QEMU_PROG_BUILD): $(all-obj-y) ../libqemuutil.a ../libqemustub.a
> -	$(call LINK,$^)
> +	$(call LINK, $(filter-out %.mak, $^))
>  
>  gdbstub-xml.c: $(TARGET_XML_FILES) $(SRC_PATH)/scripts/feature_to_c.sh
>  	$(call quiet-command,rm -f $@ && $(SHELL) $(SRC_PATH)/scripts/feature_to_c.sh $@ $(TARGET_XML_FILES),"  GEN   $(TARGET_DIR)$@")
> -- 
> MST
> 

Reviewed-by: Fam Zheng <famz@redhat.com>