From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1YQpXa-0003Nm-1p
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 22:55:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1YQpXW-0006NI-24
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 22:55:09 -0500
Received: from mail-ig0-x22e.google.com ([2607:f8b0:4001:c05::22e]:33496)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <namei.unix@gmail.com>) id 1YQpXV-0006K9-Ts
	for qemu-devel@nongnu.org; Wed, 25 Feb 2015 22:55:05 -0500
Received: by mail-ig0-f174.google.com with SMTP id b16so41412363igk.1
	for <qemu-devel@nongnu.org>; Wed, 25 Feb 2015 19:55:04 -0800 (PST)
Date: Thu, 26 Feb 2015 11:54:46 +0800
From: Liu Yuan <namei.unix@gmail.com>
Message-ID: <20150226035446.GD5811@ubuntu-trusty>
References: <87pp9f1b61.fsf@blackfin.pond.sub.org>
	<1423799142-21893-1-git-send-email-namei.unix@gmail.com>
	<87egpn7h38.fsf@blackfin.pond.sub.org>
	<20150225013953.GB6415@ubuntu-trusty>
	<87bnkigwq2.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87bnkigwq2.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH] sheepdog: fix confused return values
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: sheepdog@lists.wpkg.org, qemu-devel@nongnu.org

On Wed, Feb 25, 2015 at 10:35:17AM +0100, Markus Armbruster wrote:
> Liu Yuan <namei.unix@gmail.com> writes:
> 
> > On Wed, Feb 18, 2015 at 09:35:07AM +0100, Markus Armbruster wrote:
> >> Liu Yuan <namei.unix@gmail.com> writes:
> >> 
> >> > From: Liu Yuan <liuyuan@cmss.chinamobile.com>
> >> >
> >> > These functions mix up -1 and -errno in return values and would might cause
> >> > trouble error handling in the call chain.
> >> >
> >> > This patch let them return -errno and add some comments.
> >> >
> >> > Reported-by: Markus Armbruster <armbru@redhat.com>
> >> > Signed-off-by: Liu Yuan <liuyuan@cmss.chinamobile.com>
> >> 
> >> Did you review all functions returning negative errno, or just the two
> >> that caught my eye?
> >
> > Umm, mostly the two you mentioned.
> 
> I encourage you to review the whole file for this error pattern!  In my
> experience, bugs occur in clusters.  When you find one, there's a high
> chance similar ones exist, and looking for them is good practice.

Hi Markus, I've checked the whole file as possible as I can. I can't find more
ret mixing bugs.

Yuan