From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQqIo-0003iQ-KM for qemu-devel@nongnu.org; Wed, 25 Feb 2015 23:43:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQqIl-0003vI-Dq for qemu-devel@nongnu.org; Wed, 25 Feb 2015 23:43:58 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:49662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQqIk-0003uy-KM for qemu-devel@nongnu.org; Wed, 25 Feb 2015 23:43:55 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Feb 2015 14:43:50 +1000 Received: from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 589712CE8054 for ; Thu, 26 Feb 2015 15:43:48 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1Q4hdeM16842986 for ; Thu, 26 Feb 2015 15:43:48 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1Q4hEHQ001280 for ; Thu, 26 Feb 2015 15:43:14 +1100 Date: Thu, 26 Feb 2015 10:12:55 +0530 From: Bharata B Rao Message-ID: <20150226044255.GA14967@in.ibm.com> References: <54EBD30C.1040902@cn.fujitsu.com> <54ECAD4D.9030506@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54ECAD4D.9030506@suse.de> Subject: Re: [Qemu-devel] [PATCH v4 00/10] cpu: add device_add foo-x86_64-cpu support Reply-To: bharata@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Zhu Guihua , qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, anshul.makkar@profitbricks.com, Gu Zheng , imammedo@redhat.com On Tue, Feb 24, 2015 at 05:56:45PM +0100, Andreas Färber wrote: > Hi Gu, > > Am 24.02.2015 um 02:25 schrieb Gu Zheng: > > The issues you commented in the previous version have been fixed in this one. > > What I have repeatedly rejected is "device_add foo-x86_64-cpu". This is > still in 00/10 and 09/10. Most of the actual changes however do look to > be going in the right direction of making 'realize' work as expected for > foo-x86_64-cpu. > > As for the socket-based device_add I mentioned, I had pushed a work > branch qom-cpu-x86 and had some off-list discussions for some of the > other architectures but did not submit it as an RFC yet. What I am still > working on is dynamic properties to allocate cores (threads TBD) for > "device_add x86_64-cpu-socket,cores=n". If you have started a VM with -smp sockets=1,cores=4,threads=2, will you allow addition of a socket with just 2 cores like device_add x86_64-cpu-socket,cores=2,id=sock2 ? If so, will there be semantics to populate the remaining cores of that socket ? If so, would that look like below ? device-add x86_64-cpu-core,sock=sock2 Regards, Bharata.