From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49712) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR1rz-00009B-Sx for qemu-devel@nongnu.org; Thu, 26 Feb 2015 12:05:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YR1ru-0007xz-6L for qemu-devel@nongnu.org; Thu, 26 Feb 2015 12:05:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YR1rt-0007xr-Ue for qemu-devel@nongnu.org; Thu, 26 Feb 2015 12:04:58 -0500 Date: Thu, 26 Feb 2015 18:04:51 +0100 From: "Michael S. Tsirkin" Message-ID: <20150226170451.GA20463@redhat.com> References: <1422541482-2839-2-git-send-email-den@openvz.org> <20150219092541.GA19380@redhat.com> <54E5AEA5.8030407@openvz.org> <20150219093941.GB19380@redhat.com> <54E5B0FA.3010505@openvz.org> <20150219101732.GA24499@redhat.com> <54E5B987.9070202@openvz.org> <20150219102927.GA24587@redhat.com> <20150219122618.372cc7e7.cornelia.huck@de.ibm.com> <54EF5154.5030906@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54EF5154.5030906@openvz.org> Subject: Re: [Qemu-devel] [RESEND PATCH 1/2] balloon: call qdev_alias_all_properties for proxy dev in balloon class init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Cornelia Huck , Christian Borntraeger , qemu-devel@nongnu.org, Raushaniya Maksudova On Thu, Feb 26, 2015 at 08:01:08PM +0300, Denis V. Lunev wrote: > On 19/02/15 14:26, Cornelia Huck wrote: > >On Thu, 19 Feb 2015 11:29:27 +0100 > >"Michael S. Tsirkin" wrote: > > > >>On Thu, Feb 19, 2015 at 01:23:03PM +0300, Denis V. Lunev wrote: > >>>>The problem is code duplication: all transports need to know > >>>>about these balloon-specific property. > >>>>Why isn't it handled by virtio_instance_init_common? > >>>> > >>>why it should? > >>> > >>>virtio_instance_init_common is common for all virtio devices > >>>including VirtIO net, VirtIO block, VirtIO SCSI. Thus the patch > >>>move initialization of all common stuff into the common > >>>code. > >>The problem seems common enough, virtio_instance_init_common > >>already works for all properties, why not for these ones? > >It only works for the properties that are common amongst transports and > >all devices. > > > >Adding a virtio_balloon_init_common() that adds the guest_stats (or a > >virtio_rng_init_common() that adds rng) is probably not a bad idea, but > >I'd prefer it as patches on top of these. > > > ping. Michael, what is the decision? Pls address this by sending patches on top. -- MST