From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33447)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YRJ7J-0004kn-PP
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 06:30:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YRJ7F-0005bB-AE
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 06:30:01 -0500
Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:41906)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1YRJ7F-0005b6-4n
	for qemu-devel@nongnu.org; Fri, 27 Feb 2015 06:29:57 -0500
Received: by wghl18 with SMTP id l18so19596588wgh.8
	for <qemu-devel@nongnu.org>; Fri, 27 Feb 2015 03:29:56 -0800 (PST)
Date: Fri, 27 Feb 2015 11:29:53 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150227112953.GC20354@stefanha-thinkpad.redhat.com>
References: <1424231875-7131-1-git-send-email-namei.unix@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="bKyqfOwhbdpXa4YI"
Content-Disposition: inline
In-Reply-To: <1424231875-7131-1-git-send-email-namei.unix@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] sheepdog: fix confused return values
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Yuan <namei.unix@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, sheepdog@lists.wpkg.org, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Markus Armbruster <armbru@redhat.com>


--bKyqfOwhbdpXa4YI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 18, 2015 at 11:57:55AM +0800, Liu Yuan wrote:
> From: Liu Yuan <liuyuan@cmss.chinamobile.com>
>=20
> These functions mix up -1 and -errno in return values and would might cau=
se
> trouble error handling in the call chain.
>=20
> This patch let them return -errno and add some comments.
>=20
> Cc: qemu-devel@nongnu.org
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Liu Yuan <liuyuan@cmss.chinamobile.com>
> ---
> v2:
>  - use socket_error() instead of errno
>=20
>  block/sheepdog.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

--bKyqfOwhbdpXa4YI
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJU8FUxAAoJEJykq7OBq3PIhzwH/jzhwClPTKicZGVLaRaytXcS
gia+H471CUlUdfk0SUE7lXKf9smLwLG55cmYIwplD6jMZuWAsnUoLeJE83OcejZc
e7vNZ4rKKgVntqxtLmfbA0p0wo8KqdrCDrmYe8ZwpauZutgNeZrnsahsjRa6OrGn
1EdWf89k7nUvf8ZHZzjuieu8T6AJztBYLTDKddfSr7VAjS+eA8jk6cjoeSQCPBAz
C6QOyWkskJ8TfsRF2zlOp/bF3eR0kQBMphToSvxt3xmFIqYXfOuLr1LnHVQ7/Wr4
yPXBLMGDAWN00l4j98OOO63Qg/YxLk4d5+FhBOLiHFw/WKWc/L1ig2u/siCoeZ4=
=/2ud
-----END PGP SIGNATURE-----

--bKyqfOwhbdpXa4YI--