From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47727)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YS74S-0003QB-Ob
	for qemu-devel@nongnu.org; Sun, 01 Mar 2015 11:50:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YS74O-0002rT-Bh
	for qemu-devel@nongnu.org; Sun, 01 Mar 2015 11:50:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36242)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1YS74O-0002rG-41
	for qemu-devel@nongnu.org; Sun, 01 Mar 2015 11:50:20 -0500
Date: Sun, 1 Mar 2015 17:50:11 +0100
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20150301165011.GA4290@redhat.com>
References: <1424968408-16786-1-git-send-email-mst@redhat.com>
	<54F0BA59.30808@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54F0BA59.30808@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile.objs: add dummy rule for .dsl
	files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Richard Henderson <rth@twiddle.net>

On Fri, Feb 27, 2015 at 07:41:29PM +0100, Paolo Bonzini wrote:
> 
> 
> On 26/02/2015 17:33, Michael S. Tsirkin wrote:
> > .hex files are created from .dsl files, so
> > cpp adds the dependency %.hex: %.dsl automatically,
> > but fails to add a dummy rule so if .dsl
> > file is missing, make will fail.
> > 
> > This happened to us in the past when we
> > removed some dsl files.
> > 
> > Create an extra .d file with a dummy dependency.
> > 
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/i386/Makefile.objs | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> > index 45b90a8..7a47914 100644
> > --- a/hw/i386/Makefile.objs
> > +++ b/hw/i386/Makefile.objs
> > @@ -19,6 +19,7 @@ iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \
> >  ifdef IASL
> >  #IASL Present. Generate hex files from .dsl
> >  hw/i386/%.hex: $(SRC_PATH)/hw/i386/%.dsl $(SRC_PATH)/scripts/acpi_extract_preprocess.py $(SRC_PATH)/scripts/acpi_extract.py
> > +	$(call quiet-command, echo "$<:" > "$@"-extra.d, "  DEP $@")
> >  	$(call quiet-command, $(CPP) -x c -P $(QEMU_DGFLAGS) $(QEMU_INCLUDES) $< -o $*.dsl.i.orig, "  CPP $(TARGET_DIR)$*.dsl.i.orig")
> >  	$(call quiet-command, $(PYTHON) $(SRC_PATH)/scripts/acpi_extract_preprocess.py $*.dsl.i.orig > $*.dsl.i, "  ACPI_PREPROCESS $(TARGET_DIR)$*.dsl.i")
> >  	$(call quiet-command, $(IASL) $(call iasl-option,$(IASL),-Pn,) -vs -l -tc -p $* $*.dsl.i $(if $(V), , > /dev/null) 2>&1 ,"  IASL $(TARGET_DIR)$*.dsl.i")
> > 
> 
> Applied, thanks.
> 
> Paolo

Hmm, it turns out while this helps sometimes,
sometimes this results in a hard to debug error
as we try to run preprocessor on the non-existent .dsl.

If not too late, I suggest you drop this one for now.
If too late, probably not worth reverting.

-- 
MST