From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YS7OD-0002tw-KN for qemu-devel@nongnu.org; Sun, 01 Mar 2015 12:10:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YS7OA-00012v-FM for qemu-devel@nongnu.org; Sun, 01 Mar 2015 12:10:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59613) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YS7OA-00012j-79 for qemu-devel@nongnu.org; Sun, 01 Mar 2015 12:10:46 -0500 Date: Sun, 1 Mar 2015 18:10:29 +0100 From: "Michael S. Tsirkin" Message-ID: <20150301171029.GA8233@redhat.com> References: <56ec427cdaf204091bae2df63b63a7baba88ba9b.1424912878.git.zhugh.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56ec427cdaf204091bae2df63b63a7baba88ba9b.1424912878.git.zhugh.fnst@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v3 08/10] qdev: make qdev_get_hotplug_handler() non-static List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua Cc: hutao@cn.fujitsu.com, qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, pbonzini@redhat.com, guz.fnst@cn.fujitsu.com, imammedo@redhat.com On Thu, Feb 26, 2015 at 09:16:50AM +0800, Zhu Guihua wrote: > Memory hotplug code will use qdev_get_hotplug_handler(). > > Signed-off-by: Zhu Guihua don't send patches like this pls. Just merge this with code that uses it. > --- > hw/core/qdev.c | 2 +- > include/hw/qdev-core.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index 2eacac0..2f3d1df 100644 > --- a/hw/core/qdev.c > +++ b/hw/core/qdev.c > @@ -273,7 +273,7 @@ void qdev_set_legacy_instance_id(DeviceState *dev, int alias_id, > dev->alias_required_for_version = required_for_version; > } > > -static HotplugHandler *qdev_get_hotplug_handler(DeviceState *dev) > +HotplugHandler *qdev_get_hotplug_handler(DeviceState *dev) > { > HotplugHandler *hotplug_ctrl = NULL; > > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index 15a226f..03d6239 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -266,6 +266,7 @@ int qdev_init(DeviceState *dev) QEMU_WARN_UNUSED_RESULT; > void qdev_init_nofail(DeviceState *dev); > void qdev_set_legacy_instance_id(DeviceState *dev, int alias_id, > int required_for_version); > +HotplugHandler *qdev_get_hotplug_handler(DeviceState *dev); > void qdev_unplug(DeviceState *dev, Error **errp); > void qdev_simple_device_unplug_cb(HotplugHandler *hotplug_dev, > DeviceState *dev, Error **errp); > -- > 1.9.3