From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSJNa-0003EC-RP for qemu-devel@nongnu.org; Mon, 02 Mar 2015 00:58:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSJNZ-0006We-Te for qemu-devel@nongnu.org; Mon, 02 Mar 2015 00:58:58 -0500 Date: Mon, 2 Mar 2015 11:28:35 +0530 From: Amit Shah Message-ID: <20150302055835.GF26196@grmbl.mre> References: <1425146983-16015-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425146983-16015-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] migration: Fix 32 bit compiler errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Trivial , QEMU Developer , "Dr. David Alan Gilbert" , Juan Quintela On (Sat) 28 Feb 2015 [19:09:40], Stefan Weil wrote: > Obviously that code was never before compiled on 32 bit hosts. > The RDMA API uses lots of uint64_t values and the code casts them > to and from pointers. > > I tried to fix the compilation but did not run any runtime tests. > > I think the first two patches are trivial, but the third one might > not be trivial, so please review it carefully. Interestingly Juan found this out recently as well, and Dave was taking a look. CC'ing Dave. Thanks, Amit