From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSLgm-0003ng-NX for qemu-devel@nongnu.org; Mon, 02 Mar 2015 03:27:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSLgj-0000at-Ay for qemu-devel@nongnu.org; Mon, 02 Mar 2015 03:26:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSLgj-0000am-38 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 03:26:53 -0500 Date: Mon, 2 Mar 2015 13:56:27 +0530 From: Amit Shah Message-ID: <20150302082627.GA5412@grmbl.mre> References: <1424235661-29296-1-git-send-email-david@gibson.dropbear.id.au> <20150302071516.GA1780@grmbl.mre> <20150302072812.GL29409@voom.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150302072812.GL29409@voom.fritz.box> Subject: Re: [Qemu-devel] [PATCH] Make sysbus EHCI devices ARM only by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: peter.maydell@linaro.org, kraxel@redhat.com, qemu-devel@nongnu.org On (Mon) 02 Mar 2015 [18:28:12], David Gibson wrote: > On Mon, Mar 02, 2015 at 12:45:16PM +0530, Amit Shah wrote: > > On (Wed) 18 Feb 2015 [16:01:01], David Gibson wrote: > > > A number of ARM embedded boards include EHCI USB host controllers which > > > appear as directly mapped devices, rather than sitting on a PCI bus. > > > > > > At present code to emulate such devices is included whenever EHCI support > > > is included. This patch adjusts teh config options to only include them > > > in builds targetting ARM by default. > > > > > > Signed-off-by: David Gibson > > > > After this commit, the 'pc' machine type lost a few devices, as > > noticed by the vmstate checker nightly run. Is this expected? > > > > Section "xlnx,ps7-usb" does not exist in dest > > Section "fusbh200-ehci-usb" does not exist in dest > > Section "tegra2-ehci-usb" does not exist in dest > > Section "sysbus-ehci-usb" does not exist in dest > > Section "exynos4210-ehci-usb" does not exist in dest > > Yes, that's expected. Those are all sysbus EHCI interfaces that AFAIK > are only actually used on certain ARM platforms. OK, thanks. Amit