From: Igor Mammedov <imammedo@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: ghammer@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V13 3/4] pc: add a Virtual Machine Generation ID device
Date: Mon, 2 Mar 2015 10:12:12 +0100 [thread overview]
Message-ID: <20150302101212.0e2088c1@nial.brq.redhat.com> (raw)
In-Reply-To: <20150302085039.GA2326@redhat.com>
On Mon, 2 Mar 2015 09:50:39 +0100
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Feb 25, 2015 at 05:08:52PM +0000, Igor Mammedov wrote:
> > diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h
> > index 1f678b4..a09cb3f 100644
> > --- a/include/hw/acpi/acpi.h
> > +++ b/include/hw/acpi/acpi.h
> > @@ -25,6 +25,7 @@
> > #include "qemu/option.h"
> > #include "exec/memory.h"
> > #include "hw/irq.h"
> > +#include "hw/acpi/acpi_dev_interface.h"
> >
> > /*
> > * current device naming scheme supports up to 256 memory devices
>
> BTW why is this here?
>
Yep, looks like it should have been in:
include/hw/acpi/pc-hotplug.h
I'll post patch.
next prev parent reply other threads:[~2015-03-02 9:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 17:08 [Qemu-devel] [PATCH V13 0/4] Virtual Machine Generation ID Igor Mammedov
2015-02-25 17:08 ` [Qemu-devel] [PATCH V13 1/4] acpi: extend ACPI interface to provide access to ACPI registers and SCI irq Igor Mammedov
2015-02-25 17:08 ` [Qemu-devel] [PATCH V13 2/4] docs: vm generation id device's description Igor Mammedov
2015-02-25 17:08 ` [Qemu-devel] [PATCH V13 3/4] pc: add a Virtual Machine Generation ID device Igor Mammedov
2015-02-25 19:59 ` Michael S. Tsirkin
2015-02-26 14:05 ` Igor Mammedov
2015-03-01 15:09 ` Michael S. Tsirkin
2015-03-02 17:05 ` Igor Mammedov
2015-03-02 17:20 ` Laszlo Ersek
2015-03-02 21:06 ` Michael S. Tsirkin
2015-03-03 1:03 ` David Gibson
2015-03-03 8:07 ` Michael S. Tsirkin
2015-03-03 11:06 ` Igor Mammedov
2015-03-05 2:51 ` David Gibson
2015-03-05 8:35 ` Michael S. Tsirkin
2015-03-02 8:50 ` Michael S. Tsirkin
2015-03-02 9:12 ` Igor Mammedov [this message]
2015-02-25 17:08 ` [Qemu-devel] [PATCH V13 4/4] tests: add a unit test for the vmgenid device Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302101212.0e2088c1@nial.brq.redhat.com \
--to=imammedo@redhat.com \
--cc=ghammer@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).