From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMOh-0004as-Lj for qemu-devel@nongnu.org; Mon, 02 Mar 2015 04:12:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSMOe-0006R6-GP for qemu-devel@nongnu.org; Mon, 02 Mar 2015 04:12:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSMOe-0006Qy-9P for qemu-devel@nongnu.org; Mon, 02 Mar 2015 04:12:16 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t229CFKu005040 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Mar 2015 04:12:15 -0500 Date: Mon, 2 Mar 2015 10:12:12 +0100 From: Igor Mammedov Message-ID: <20150302101212.0e2088c1@nial.brq.redhat.com> In-Reply-To: <20150302085039.GA2326@redhat.com> References: <1424884133-323-1-git-send-email-imammedo@redhat.com> <1424884133-323-4-git-send-email-imammedo@redhat.com> <20150302085039.GA2326@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V13 3/4] pc: add a Virtual Machine Generation ID device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: ghammer@redhat.com, qemu-devel@nongnu.org On Mon, 2 Mar 2015 09:50:39 +0100 "Michael S. Tsirkin" wrote: > On Wed, Feb 25, 2015 at 05:08:52PM +0000, Igor Mammedov wrote: > > diff --git a/include/hw/acpi/acpi.h b/include/hw/acpi/acpi.h > > index 1f678b4..a09cb3f 100644 > > --- a/include/hw/acpi/acpi.h > > +++ b/include/hw/acpi/acpi.h > > @@ -25,6 +25,7 @@ > > #include "qemu/option.h" > > #include "exec/memory.h" > > #include "hw/irq.h" > > +#include "hw/acpi/acpi_dev_interface.h" > > > > /* > > * current device naming scheme supports up to 256 memory devices > > BTW why is this here? > Yep, looks like it should have been in: include/hw/acpi/pc-hotplug.h I'll post patch.