From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSPHY-0002Ul-Io for qemu-devel@nongnu.org; Mon, 02 Mar 2015 07:17:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSPHT-0004Eh-EL for qemu-devel@nongnu.org; Mon, 02 Mar 2015 07:17:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSPHT-0004EN-7J for qemu-devel@nongnu.org; Mon, 02 Mar 2015 07:17:03 -0500 Date: Mon, 2 Mar 2015 13:16:51 +0100 From: "Michael S. Tsirkin" Message-ID: <20150302121651.GC12040@redhat.com> References: <1425296404-12903-1-git-send-email-mst@redhat.com> <1425296404-12903-2-git-send-email-mst@redhat.com> <20150302125655.50a9063a.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150302125655.50a9063a.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-pci: switch to modern accessors for 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: Rusty Russell , qemu-devel@nongnu.org, Anthony Liguori , virtualization@lists.linux-foundation.org On Mon, Mar 02, 2015 at 12:56:55PM +0100, Cornelia Huck wrote: > On Mon, 2 Mar 2015 12:40:28 +0100 > "Michael S. Tsirkin" wrote: > > > virtio 1.0 config space is in LE format for all > > devices, use modern wrappers when accessed through > > the 1.0 BAR. > > > > Reported-by: Rusty Russell > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/virtio/virtio-pci.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > Not that I'm deeply familiar with pci :), but this looks good to me. > > (This is on top of your pci branch, btw?) virtio 1.0 branch