From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSRsh-00085Z-W5 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:03:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSRse-0006bD-Py for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:03:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSRse-0006b9-H0 for qemu-devel@nongnu.org; Mon, 02 Mar 2015 10:03:36 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t22F3ZW9004926 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 2 Mar 2015 10:03:35 -0500 Date: Mon, 2 Mar 2015 16:03:31 +0100 From: Igor Mammedov Message-ID: <20150302160331.3bc8da44@nial.brq.redhat.com> In-Reply-To: <20150302145019.GL681446@andariel.home> References: <1424980156-25556-1-git-send-email-lcapitulino@redhat.com> <1424980156-25556-2-git-send-email-lcapitulino@redhat.com> <20150302145019.GL681446@andariel.home> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-options.hx: improve -m description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa Cc: qemu-devel@nongnu.org, Luiz Capitulino On Mon, 2 Mar 2015 15:50:19 +0100 Peter Krempa wrote: > On Thu, Feb 26, 2015 at 14:49:15 -0500, Luiz Capitulino wrote: > > Add memory hotplug options to the command-line format. Also, > > add a complete command-line example and improve description. > > > > Signed-off-by: Luiz Capitulino > > --- > > qemu-options.hx | 23 ++++++++++++++++++----- > > 1 file changed, 18 insertions(+), 5 deletions(-) > > > > diff --git a/qemu-options.hx b/qemu-options.hx > > index 85ca3ad..1634175 100644 > > --- a/qemu-options.hx > > +++ b/qemu-options.hx > > @@ -237,12 +237,25 @@ DEF("m", HAS_ARG, QEMU_OPTION_m, > > "NOTE: Some architectures might enforce a specific granularity\n", > > QEMU_ARCH_ALL) > > STEXI > > -@item -m [size=]@var{megs} > > +@item -m [size=]@var{megs}[,slots=n,maxmem=size] > > @findex -m > > -Set virtual RAM size to @var{megs} megabytes. Default is 128 MiB. Optionally, > > -a suffix of ``M'' or ``G'' can be used to signify a value in megabytes or > > -gigabytes respectively. Optional pair @var{slots}, @var{maxmem} could be used > > -to set amount of hotluggable memory slots and possible maximum amount of memory. > > +Sets guest startup RAM size to @var{megs} megabytes. Default is 128 MiB. > > +Optionally, a suffix of ``M'' or ``G'' can be used to signify a value in > > +megabytes or gigabytes respectively. Optional pair @var{slots}, @var{maxmem} > > +could be used to set amount of hotpluggable memory slots and maximum amount of > > +memory. > > + > > +For example, the following command-line sets the guest startup RAM size to > > +1GB, creates 3 slots to hotplug additional memory and sets the maximum > > +memory the guest can reach to 4GB: > > + > > +@example > > +qemy-system-i386 -m 1G,slots=3,maxmem=4G > > +@end example > > + > > +If @var{slots} and @var{maxmem} are not specified, memory hotplug won't > > +be enabled and the guest startup RAM will never increase (although it can > > +be decreased with the use of ballooning). > > ETEXI > > It might be also worth noting that maxmem has to be aligned to the page > size. See: > http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg04345.html > > (unfortunately it was not merged yet for some reason ...) it wasn't lost, it's in the last (today's) pull req from PCI tree. > > Peter